Markdown Interface Updates #9267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- "Editor" button text fixed to "Edit" - Edit and Preview buttons stay highlighted based on current mode - Added interface option for Editor and Preview Font type - Copied WYSIWYG CSS correct stylings to Markdown - Added custom block option placeholders for each input - Changed icon heading to use format_size icon - Added toolbar controls
azrikahar
suggested changes
Oct 31, 2021
- Edit translation string for name in placeholder - Wrapped preview hidden toolbars with a <template v-if> - Changed .indexOf to .includes - Added translation strings for Edit and Preview
|
@rclee91 Thanks for the prompt commit to resolve the requested changes! Also appreciate the "drive-by" changes to use the CSS variables where applicable. |
azrikahar
approved these changes
Oct 31, 2021
|
Thanks @rclee91!! We'll review! ❤️ |
rijkvanzanten
requested changes
Nov 1, 2021
I'm not sure why but it seems to work for me
|
|
Ahh but those aren't the correct fonts though. We should make sure it's using the var(--family-sans-serif) et al. fonts to match the design language of the app 👍🏻 |
- "Editor" button text fixed to "Edit" - Edit and Preview buttons stay highlighted based on current mode - Added interface option for Editor and Preview Font type - Copied WYSIWYG CSS correct stylings to Markdown - Added custom block option placeholders for each input - Changed icon heading to use format_size icon - Added toolbar controls
- Edit translation string for name in placeholder - Wrapped preview hidden toolbars with a <template v-if> - Changed .indexOf to .includes - Added translation strings for Edit and Preview
Newest commit 874783a gives these styles now. |
joselcvarela
reviewed
Nov 8, 2021
joselcvarela
approved these changes
Nov 8, 2021
rijkvanzanten
approved these changes
Dec 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worked on issue #9167
Fixes #9167