Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement AUTH_DISABLE_DEFAULT config option #9322

Merged
merged 9 commits into from Dec 3, 2021
Merged

Implement AUTH_DISABLE_DEFAULT config option #9322

merged 9 commits into from Dec 3, 2021

Conversation

dorianim
Copy link
Contributor

@dorianim dorianim commented Nov 1, 2021

Hi,

In this PR I have implemented a new config option AUTH_DISABLE_DEFAULT following the discussion over here.
I am not sure if I there is a better way to implement it, as I am very new to Directus. So I'd be happy about some feedback 馃檪

Regards,
Dorian

@aidenfoxx
Copy link
Contributor

You should probably also disable the default auth route, otherwise it'll error if you try and call it.

router.use('/login', createLocalAuthRouter(DEFAULT_AUTH_PROVIDER));

But really nice work man. Nice and clean!

@dorianim
Copy link
Contributor Author

dorianim commented Nov 1, 2021

Yep, you're right and thanks 馃檪

@aidenfoxx
Copy link
Contributor

Last thing would be to add the disableDefault flag to the API docs, then I'm happy. https://github.com/directus/directus/blob/main/docs/reference/authentication.md#response-attributes-2

@dorianim
Copy link
Contributor Author

dorianim commented Nov 1, 2021

Yep, of course 馃憤

Co-authored-by: Aiden Foxx <aiden.foxx.mail@gmail.com>
app/src/routes/login/login.vue Outdated Show resolved Hide resolved
@dorianim
Copy link
Contributor Author

dorianim commented Nov 3, 2021

Ok, so I think it's done :)

@rijkvanzanten rijkvanzanten removed this from the v9.0.0-rc.101 milestone Nov 4, 2021
@dorianim
Copy link
Contributor Author

@rijkvanzanten I think, this is ready to merge 馃檪

@rijkvanzanten rijkvanzanten added this to the v9.2.0 milestone Dec 3, 2021
@rijkvanzanten rijkvanzanten self-assigned this Dec 3, 2021
@rijkvanzanten rijkvanzanten merged commit 94e5321 into directus:main Dec 3, 2021
@dorianim dorianim deleted the feat/disable-default-auth-provider branch December 3, 2021 21:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants