Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter option to public registration #9363

Closed
wants to merge 16 commits into from
Closed

Conversation

jamescammarano
Copy link
Contributor

@jamescammarano jamescammarano commented Nov 2, 2021

Implements #9031

Goals:
Add ability to filter who can register as a Directus user based on configurable filters.

  • oath2
  • openid
  • Docs
  • Tests?

api/src/auth/drivers/oauth2.ts Outdated Show resolved Hide resolved
@jamescammarano jamescammarano marked this pull request as ready for review November 2, 2021 19:51
@rijkvanzanten
Copy link
Member

AHA! Well, that's pretty semantically confusing here, but as long as it's correct! 😂

100% agree here.

@jaycammarano Could you do me/us a favor, and find-and-replace the current validatePayload function for getValidationErrors, and then create a new validatePayload function that returns a boolean to indicated whether or not the payload validates? That should clean up this confusion nicely 👍🏻

docs/configuration/config-options.md Outdated Show resolved Hide resolved
docs/configuration/config-options.md Outdated Show resolved Hide resolved
@jamescammarano
Copy link
Contributor Author

jamescammarano commented Nov 2, 2021

AHA! Well, that's pretty semantically confusing here, but as long as it's correct! 😂

100% agree here.

@jaycammarano Could you do me/us a favor, and find-and-replace the current validatePayload function for getValidationErrors, and then create a new validatePayload function that returns a boolean to indicated whether or not the payload validates? That should clean up this confusion nicely 👍🏻

I renamed it but if we change it to a boolean how will we log what didn't pass validation. I did make that boolean function though I just haven't pushed it.

I guess we could run getValidationerrors() in the if still

@jamescammarano jamescammarano marked this pull request as draft November 2, 2021 22:45
@jamescammarano jamescammarano marked this pull request as ready for review November 2, 2021 23:51
@rijkvanzanten
Copy link
Member

Heya, thanks for your PR! Our small team has been attempting to work through a backlog of external contributions for the better part of a year, but in that time many have become too stale to merge or the change is no longer desired/relevant..
We've updated the contributing guidelines and are working on making more resources available to make sure that doesn’t happen again 😬 In the meantime, we'll have to close this PR for now..

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants