Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tree view interface display template #9600

Merged
merged 1 commit into from Dec 1, 2021
Merged

fix tree view interface display template #9600

merged 1 commit into from Dec 1, 2021

Conversation

azrikahar
Copy link
Contributor

fixes #9511

The interface prop for the template is displayTemplate:

displayTemplate: {
type: String,
default: undefined,
},

but the interface configuration field is saving it as template:

{
field: 'template',
name: '$t:display_template',
meta: {
interface: 'system-display-template',
options: {
collectionName: collection,
},
width: 'full',
},
},


Even though this fixes it, now every existing tree views might end up saving this to the DB (example taken from what I have now):

{"template":"{{label}}{{id}}","displayTemplate":"{{label}}"}

so the old "template" property will be dangling here. Not sure should we note this in the release.

@calbrecht
Copy link

calbrecht commented Nov 8, 2021

Not sure should we note this in the release.

From a user perspective i would be glad to be notified about it, even more happy if there was a migration to fix it, although i must admit i do not have a clue if this is in the scope of migrations :)

@calbrecht
Copy link

I confirm this fixes #9511 after editing the Interface Display.

@rijkvanzanten rijkvanzanten added this to the v9-next milestone Dec 1, 2021
@rijkvanzanten rijkvanzanten merged commit 5feaac8 into main Dec 1, 2021
@rijkvanzanten rijkvanzanten deleted the issue/9511 branch December 1, 2021 21:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interface Display Template of TreeView not showing configured relative values within Drag'n'Drop Item Preview.
3 participants