-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for discarding of changes without leaving #9644
Conversation
I'm wondering about the 80/20 of this. Is navigating away to cancel out of editing the item too cumbersome? Also a little curious if there's a UX problem with two very opposite actions so close together ("save" vs "undo everything"). Thoughts @benhaynes? |
I don't mind having the explicit option to leave without saving... so there's a very clear option for that. Still, it's the same number of clicks for this versus hitting "back" and "confirm". :) |
I added it as I've been debugging the form side of things. Often, making changes to a field and the only way to get the original value back was to click back, confirm, then re-enter. That's 3 clicks in total, with delays due to reloading of data required...
Indeed, they are opposite. Will it be better if a divider is added before the discard changes option? |
Happy with or without a divider. It's already clear, bt we could also say: |
* Allow for discarding of changes without leaving * Update to use v-if for consistency * Fix boolean logic * Allow disabling of options * Remove unused disabled prop
Closes #9642.
It is implemented alongside
save-options
so that there is no need to prompt for confirmation, same as save as copy etc.