Add default values when tracking edits in list interface #9707
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9538
Context
When we first click
block
in Markdown custom blocks, it works. But when we try to revert back toinline
, nothing seems to happen.Investigation
The update:model-value for the list form was modified in #8169 here:
directus/app/src/interfaces/list/list.vue
Lines 215 to 217 in 194862c
However due to the nature of "if input is the same as the default value", in this case the default is
inline
, the doesn't end up emittingbox: inline
here because theunset
kicks in:directus/app/src/components/v-form/form-field.vue
Lines 163 to 173 in 194862c
Hence the
updatedValues
intrackEdits()
above never has the propertybox
, so it stays asblock
.Fix
Added defaults in case the
updatedValues
doesn't have specific properties, implying it should "revert" to the default value when we assign it to edits.value.Also added a line to clear edits value when the drawer is closed.