Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify presentation/aliases & accordion setup flow #9742

Merged
merged 5 commits into from Dec 1, 2021
Merged

Conversation

azrikahar
Copy link
Contributor

@azrikahar azrikahar commented Nov 12, 2021

resolves #9528

Criteria of affected interfaces: they have hideLabel set as true, which includes

  • Presentation - Divider
  • Presentation - Links
  • Presentation - Notice
  • Group - Accordion

Result

Data Model page

image

Setup flow

NhurqrhZnF.mp4

@benhaynes
Copy link
Sponsor Member

Sooo much better than before.... turned out great!

Also, a side note for another issue, we should override the repeaters background color variable to use the inverse color (white). That will give those rows contrast again.

@azrikahar
Copy link
Contributor Author

Sooo much better than before.... turned out great!

Also, a side note for another issue, we should override the repeaters background color variable to use the inverse color (white). That will give those rows contrast again.

Just to confirm, you mean the one in Button Links right?

The items themselves do have a good contrast:

chrome_Vg7MzAYH4O

But seems like the No Item notice is the one "sharing" the same color. Here's the current applied fix to it:

chrome_7WgHy5PN8I

chrome_mHbY95GLB9

@benhaynes
Copy link
Sponsor Member

Ahh, makes sense. Thank you!

@rijkvanzanten rijkvanzanten added this to the v9-next milestone Dec 1, 2021
@rijkvanzanten rijkvanzanten enabled auto-merge (squash) December 1, 2021 21:25
@rijkvanzanten rijkvanzanten merged commit 0dc0fd4 into main Dec 1, 2021
@rijkvanzanten rijkvanzanten deleted the alias-flow branch December 1, 2021 21:29
@stx-chris
Copy link

Directus 9.5.1: I wanted to try this cool feature but as soon as the read-permissions for a role is restricted (removing a single field permission is enough), all notices disappear for that user. The notices seem to be displayed only if the role has full read permissions on the collection. Also, notices don't appear in the field permission list. Intention or bug?

@azrikahar
Copy link
Contributor Author

@stx-chris this PR doesn't add Notice as they are added long before this. Here we're just implementing auto-id-generation, so I believe this is an unrelated thing here.

With that said, that does sound like a bug so it'll be helpful if you can submit an issue with minimal reproduction steps 👍

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Divider/Alias setup flow
4 participants