Clear selections after batch edit #9798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If Auto Refresh is Enabled like every 10 Sec. We should only clear when the save is submitted or the change is discarded. |
Ah good one! Will update it to prevent that from happening. |
rijkvanzanten
requested changes
Nov 15, 2021
rijkvanzanten
approved these changes
Dec 1, 2021
rijkvanzanten
pushed a commit
that referenced
this pull request
Dec 1, 2021
* Clear selections after batch edit * remove redundant selection clears * only refresh after batch saving * use clearer function name
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Ref #9791, saving after a batch edit doesn't clear the previous selections. This is more of an issue when there's a filter, which will cause future batch edits to still include the ones that are filtered out already.
Xb2TMbeKa4.mp4
Fix applied
refresh()refresh()nowDid thought of clearing selections by removing only ones that does not exist anymore in current items, but selections on page 2 for example will not be cleared in this case. Downside of current solution will indeed impact users that does batch edits consecutively on the same selections, but the number of users with this specific use case should be not that many...