fix: close tmp file

direnv · Apr 15, 2024 · 2f7a90e · 2f7a90e
1 parent 6a73cc2
commit 2f7a90e
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/internal/cmd/cmd_fetchurl.go b/internal/cmd/cmd_fetchurl.go
@@ -73,7 +73,8 @@ func cmdFetchURL(_ Env, args []string, config *Config) (err error) {
 		return err
 	}
 	defer resp.Body.Close()
-
+	defer tmpfile.Close()
+
 	// Abort if we don't get a 200 back
 	if resp.StatusCode != 200 {
 		return fmt.Errorf("expected status code 200 but got %d", resp.StatusCode)
@@ -104,6 +105,10 @@ func cmdFetchURL(_ Env, args []string, config *Config) (err error) {
 
 	// Put the file into the CAS store if it's not already there
 	if !fileExists(casFile) {
+		err = tmpfile.Close()
+		if err != nil {
+    			return err
+		}
 		// Move the temporary file to the CAS location.
 		if err = os.Rename(tmpfile.Name(), casFile); err != nil {
 			return err