Skip to content
This repository has been archived by the owner on Apr 27, 2024. It is now read-only.

refactor: Prepare for dirigeants/klasa#862 #211

Merged
merged 3 commits into from
Nov 6, 2019

Conversation

kyranet
Copy link
Contributor

@kyranet kyranet commented Nov 6, 2019

Description of the PR

I heard you like refactors. Requires dirigeants/klasa#862 to land first.

Changes Proposed in this Pull Request (List new items in CHANGELOG.MD)

  • Rewritten MemberGateway to use SG's new cool stuff.

Semver Classification

  • This PR only includes documentation or non-code changes.
  • This PR fixes a bug and does not change the (intended) framework interface.
  • This PR adds methods or properties to the framework interface.
  • This PR removes or renames methods or properties in the framework interface.

@kyranet kyranet added the Blocked label Nov 6, 2019
@lgtm-com
Copy link

lgtm-com bot commented Nov 6, 2019

This pull request introduces 1 alert when merging f8812d8 into b8503a9 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@kyranet kyranet removed the Blocked label Nov 6, 2019
@kyranet kyranet merged commit 80c5146 into settings Nov 6, 2019
@kyranet kyranet deleted the settings-sync-queue-refactor branch November 6, 2019 18:21
@PyroTechniac PyroTechniac mentioned this pull request Dec 9, 2019
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant