This repository has been archived by the owner on Jun 2, 2020. It is now read-only.
Save an extra fetch by storing the data fetched for page 1 #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change to pagination mechanism - when loading pagination info, data for page 1 is loaded but currently not stored. When asking for page 1, the data is loaded - again. Example script:
Output without this change shows an extra fetch:
Iterating over releases...
GET https://api.discogs.com/artists/251558
GET https://api.discogs.com/artists/251558/releases?per_page=50&page=1
GET https://api.discogs.com/artists/251558/releases?per_page=50&page=1
GET https://api.discogs.com/artists/251558/releases?per_page=50&page=2
...
After the fix, page 1 is no longer loaded twice:
Iterating over releases...
GET https://api.discogs.com/artists/251558
GET https://api.discogs.com/artists/251558/releases?per_page=50&page=1
GET https://api.discogs.com/artists/251558/releases?per_page=50&page=2
...