Merge pull request #95 from shayypy/empty-embed-warning

Empty embed warning

common/utilities/joinText.ts

@@ -0,0 +1,6 @@
+export const joinWithAnd = (parts: string[]): string => {
+  if (parts.length === 1) return parts[0]
+  const firsts = parts.slice(0, parts.length - 1)
+  const last = parts[parts.length - 1]
+  return `${firsts.join(", ")}${parts.length > 2 ? "," : ""} and ${last}`
+}

modules/editor/message/MessageEditor.tsx

@@ -11,6 +11,7 @@ import { ButtonList } from "../../../common/layout/ButtonList"
 import { Stack } from "../../../common/layout/Stack"
 import { ModalManagerContext } from "../../../common/modal/ModalManagerContext"
 import { useRequiredContext } from "../../../common/state/useRequiredContext"
+import { joinWithAnd } from "../../../common/utilities/joinText"
 import { Markdown } from "../../markdown/Markdown"
 import type { MessageItemFormState } from "../../message/state/editorForm"
 import type { EmbedLike } from "../../message/state/models/EmbedModel"
@@ -64,6 +65,10 @@ export function MessageEditor(props: MessageEditorProps) {
       ),
     })
 
+  const emptyEmbedNumbers = message.embeds
+    .map((embed, index) => (!embed.displayName ? index + 1 : -1))
+    .filter(index => index !== -1)
+
   return useObserver(() => (
     <Stack gap={16}>
       <PrimaryContentEditor message={message} form={form} />
@@ -78,6 +83,19 @@ export function MessageEditor(props: MessageEditorProps) {
               }
             />
           </EmbedValidationErrorContainer>
+          <EmbedValidationErrorContainer>
+            <InputError
+              error={
+                emptyEmbedNumbers.length === 1
+                  ? `Embed ${emptyEmbedNumbers[0]} is empty`
+                  : emptyEmbedNumbers.length > 1
+                  ? `Embeds ${joinWithAnd(
+                      emptyEmbedNumbers.map(String),
+                    )} are empty`
+                  : undefined
+              }
+            />
+          </EmbedValidationErrorContainer>
           <Stack gap={16}>
             {message.embeds.map((embed, index) => (
               <EmbedEditor