Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md, explain running container, specify node 16 #102

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

b-rad15
Copy link
Contributor

@b-rad15 b-rad15 commented Oct 17, 2023

Update README.md to explain running via published container and specified node version 16 to match the version used by the CI image

Wanted to try and make this as simple as possible for people to self host in the event the site ever goes down

Update README.md to explain running via published container and specified node version 16 to match the version used by the CI image
@maddysrc
Copy link
Member

Probably long overdue so thanks, but why -t?

@b-rad15
Copy link
Contributor Author

b-rad15 commented Oct 17, 2023

Without that there isn't color output, at least for podman desktop's logs and windows terminal. Not much but does something.

@maddysrc
Copy link
Member

I wouldn't exactly colour output important, especially considering it can mess with output.

@b-rad15
Copy link
Contributor Author

b-rad15 commented Oct 17, 2023

Ah ok, have never had output messed up by it (except for piping of course, but if you're doing that you probably know well enough to not use -t). If it can mess up something then yeah may as well leave it off.

@maddysrc
Copy link
Member

but if you're doing that you probably know well enough to not use -t

I don't agree, people generally struggle parsing what container technology even means and launch args like --tty is only going to confuse.

@b-rad15
Copy link
Contributor Author

b-rad15 commented Oct 18, 2023

Agree to disagree I guess. I think errors in obvious red for random users is more important than possibly having advanced users have to debug why not to use -t, but if you think it's better to not have -t there then feel free to change it. Either way it's not a huge difference.

README.md Outdated Show resolved Hide resolved
@maddysrc maddysrc merged commit 57af9e7 into discohook:main Oct 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants