Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No way to avoid douplicate webhook events #13

Closed
ilovelinux opened this issue Oct 5, 2022 · 0 comments · Fixed by #14
Closed

No way to avoid douplicate webhook events #13

ilovelinux opened this issue Oct 5, 2022 · 0 comments · Fixed by #14

Comments

@ilovelinux
Copy link
Contributor

ilovelinux commented Oct 5, 2022 •
edited

As written on https://shopify.dev/apps/webhooks/best-practices#ignore-duplicates Shopify could send duplicate webhook events. In order to avoid that, devs should double-check the X-Shopify-Webhook-Id header value.

Sadly, there's apparently no way to get that header from signals.

It could be useful to pass request here: https://github.com/discolabs/django-shopify-webhook/blob/master/shopify_webhook/views.py#L35-L36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Webhook ID argument to signals (allow to fix #13) ilovelinux/django-shopify-webhook
1 participant
@ilovelinux