Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Webhook ID argument to signals (allow to fix #13) #14

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Add Webhook ID argument to signals (allow to fix #13) #14

merged 2 commits into from
Sep 5, 2023

Conversation

ilovelinux
Copy link
Contributor

@ilovelinux ilovelinux commented Dec 25, 2022 •
edited

Fix #13

@ilovelinux
Copy link
Contributor Author

@gavinballard any chance to have a review? 🙂

Being unable to check whether a webhook has already been processed or not may be very limiting in certain use cases.

@gavinballard gavinballard requested a review from stlk August 8, 2023 12:04
@gavinballard
Copy link
Member

Nudging @stlk on the off chance he's still around :)

@stlk stlk merged commit 3f6f886 into discolabs:master Sep 5, 2023
@stlk
Copy link
Collaborator

stlk commented Sep 5, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stlk stlk Awaiting requested review from stlk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No way to avoid douplicate webhook events
3 participants
@ilovelinux @gavinballard @stlk