Chunker forget chunks if input matches hunk size #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
previous commit comment: dangra@58fa396#commitcomment-566696 |
|
My first patch to this issue switched checks from hunk_size to chunk size, but it introduced a new bug. So this final pull request has a proper patch with tests and prove why checking both, hunk_size and chunk size is required. more info: https://groups.google.com/forum/#!topic/disco-dev/MxVMhnGgMXI |
tuulos
pushed a commit
that referenced
this pull request
Sep 22, 2011
Chunker forget chunks if input matches hunk size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disco.fileutils.Chunkerignores the last chunk if input matches the size of a hunk. I thinkChunkeris wrongly checkingout.hunk_sizefor pending data and should checkout.sizetoo,out.sizeis reseted only after a chunk is flushed, hunks resets more often within a chunk.