New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chunker forget chunks if input matches hunk size #272

Merged
merged 1 commit into from Sep 22, 2011

Conversation

Projects
None yet
2 participants
@dangra
Contributor

dangra commented Aug 24, 2011

disco.fileutils.Chunker ignores the last chunk if input matches the size of a hunk. I think Chunker is wrongly checking out.hunk_size for pending data and should check out.size too, out.size is reseted only after a chunk is flushed, hunks resets more often within a chunk.

@dangra

This comment has been minimized.

Show comment
Hide comment
@dangra

dangra Sep 9, 2011

Contributor

previous commit comment: dangra@58fa396#commitcomment-566696

Contributor

dangra commented Sep 9, 2011

previous commit comment: dangra@58fa396#commitcomment-566696

@dangra

This comment has been minimized.

Show comment
Hide comment
@dangra

dangra Sep 9, 2011

Contributor

My first patch to this issue switched checks from hunk_size to chunk size, but it introduced a new bug. So this final pull request has a proper patch with tests and prove why checking both, hunk_size and chunk size is required.

more info: https://groups.google.com/forum/#!topic/disco-dev/MxVMhnGgMXI

Contributor

dangra commented Sep 9, 2011

My first patch to this issue switched checks from hunk_size to chunk size, but it introduced a new bug. So this final pull request has a proper patch with tests and prove why checking both, hunk_size and chunk size is required.

more info: https://groups.google.com/forum/#!topic/disco-dev/MxVMhnGgMXI

tuulos pushed a commit that referenced this pull request Sep 22, 2011

Ville Tuulos
Merge pull request #272 from dangra/chunker-forgets-hunks
Chunker forget chunks if input matches hunk size

@tuulos tuulos merged commit 0f08971 into discoproject:master Sep 22, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment