Add GuildImpl#invalidate #1227
Closed
Add GuildImpl#invalidate #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DV8FromTheWorld
approved these changes
Aug 8, 2020
|
Is there a reason we didn't go ahead with this change? |
|
I added this for the purpose of auto-sharding, but I never got to it, so now it's just stale. To merge this we would need to check if any changes need to be addressed since this PR was created. |
|
We should consider resurrecting this as we just encountered a situation where the cache didn't get cleared because invalidation was forgotten. Having this all in one place would be nice. #2029 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Closes Issue: NaN
Description
This will be very useful for the new auto-sharding.