Add missing cache cleanup for news/stage/thread channels #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With that logic, stage channels should behave the same way too |
You are right, didn't notice that |
Mitmocc
changed the title
MinnDevelopment
approved these changes
Feb 19, 2022
DV8FromTheWorld
approved these changes
Feb 19, 2022
6 tasks
This was referenced Feb 20, 2022
Closed
This was referenced Mar 3, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Closes Issue: NaN
Description
There is a bug where if you kick a bot from a guild and then re-invite it, news channels would return null if fetched from the jda instance. I don't understand it fully but there might be objects of the newsChannel left when the bot is kicked because the GuildDeleteHandler wasn't cleaning the global cache from the news channels. This change fixes that bug.
Edit: Same thing applied to stage channels and thread channels, so I added those too.