Implement user banner & banner color #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Placed in freezer until Docs PR is merged |
|
The docs PR has been merged. |
RedDaedalus
changed the title
MinnDevelopment
requested changes
Aug 30, 2021
src/main/java/net/dv8tion/jda/api/events/user/update/UserUpdateAccentColorEvent.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/api/events/user/update/UserUpdateAccentColorEvent.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/api/events/user/update/UserUpdateAccentColorEvent.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/api/events/user/update/UserUpdateBannerEvent.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/entities/EntityBuilder.java
Outdated
Show resolved
Hide resolved
• Adds `getAccentColorRaw` method for the accent color. • Adds missing copyright to events. • Clarifies some docs and adds missing annotations.
src/main/java/net/dv8tion/jda/internal/entities/EntityBuilder.java
Outdated
Show resolved
Hide resolved
|
All of these new properties are related to a user's profile. |
|
Just went through reviews, apologies for the delay here. |
Sanduhr32
reviewed
Sep 28, 2021
Closed
MinnDevelopment
requested changes
Nov 5, 2021
src/main/java/net/dv8tion/jda/internal/entities/EntityBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/entities/EntityBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/entities/EntityBuilder.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Florian Spieß <business@minn.dev>
…java Co-authored-by: Florian Spieß <business@minn.dev>
Co-authored-by: Florian Spieß <business@minn.dev>
Co-authored-by: Florian Spieß <business@minn.dev>
Co-authored-by: Florian Spieß <business@minn.dev>
…java Co-authored-by: Florian Spieß <business@minn.dev>
…java Co-authored-by: Florian Spieß <business@minn.dev>
|
All review suggestions have been committed. |
|
For the future, you can batch apply suggestions for code review... |
MinnDevelopment
approved these changes
Nov 6, 2021
Stonedestroyer
pushed a commit
to Stonedestroyer/JDA
that referenced
this pull request
Nov 11, 2021
Co-authored-by: Florian Spieß <business@minn.dev>
This was referenced Jan 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Closes Issue: NaN
Description
Implements basic support for user banners. This is not very usable currently, missing docs, and is expected to break when the Discord API is changed shortly.
Docs PR: discord/discord-api-docs#3448
Considerations
• Banner information is only sent when the user is specifically requested, a method to retrieve this might be beneficial.
• The handling of unknown state from passively gathered user objects
• The changes that will be made to the
banner_colorfield are currently not known in detail.