Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document banner & banner color #3448

Merged
merged 12 commits into from
Aug 16, 2021
Merged

Document banner & banner color #3448

merged 12 commits into from
Aug 16, 2021

Conversation

RedDaedalus
Copy link
Contributor

The user's banner and banner color appear to only be returned on the canary API currently, and only a small percentage of users can set their banner color.

@PixeLInc
Copy link
Contributor

Perhaps you'd want to also document the image formatting reference: /banners/user_id/user_banner

@RedDaedalus
Copy link
Contributor Author

RedDaedalus commented Jul 14, 2021

Perhaps you'd want to also document the image formatting reference: /banners/user_id/user_banner

Done.

docs/Reference.md Outdated Show resolved Hide resolved
docs/Reference.md Outdated Show resolved Hide resolved
docs/Reference.md Outdated Show resolved Hide resolved
Co-authored-by: Advaith <advaithj1@gmail.com>
@advaith1
Copy link
Member

q for staff: is there a reason banner_color is sent as a string, and not as an integer? embed colors and role colors are sent as integers, so this is inconsistent

@advaith1
Copy link
Member

re ^, they'll change it to an integer

image

docs/resources/User.md Outdated Show resolved Hide resolved
@typpo
Copy link
Contributor

typpo commented Jul 19, 2021

This is still an experiment and therefore the API is subject to change, will revisit once the feature is finalized

RedDaedalus and others added 2 commits July 19, 2021 15:27
Co-authored-by: Florian Spieß <business@minnced.club>
@RedDaedalus
Copy link
Contributor Author

accent_color is now sent with the proper int type.

@GoldenAngel2
Copy link
Contributor

GoldenAngel2 commented Jul 19, 2021

It looks like both are still being sent should both be documented? or have banner_color marked as deprecated.

@RedDaedalus also the user example needs to be updated.

l7ssha added a commit to nyxx-discord/nyxx that referenced this pull request Jul 19, 2021
@typpo typpo merged commit 0d954e6 into discord:master Aug 16, 2021
Nihlus added a commit to Remora/Remora.Discord that referenced this pull request Aug 18, 2021
@RedDaedalus RedDaedalus deleted the user-banner branch August 29, 2021 05:26
7596ff pushed a commit to twilight-rs/twilight that referenced this pull request Sep 17, 2021
Add the new `accent_color` and `banner` fields. `accent_color` is an
integer representation of the RGB color while `banner` is a hash of the
user's banner image.

This is documented in the API docs:
<discord/discord-api-docs#3448>

Closes #1126.
MaxOhn pushed a commit to MaxOhn/twilight that referenced this pull request Oct 7, 2021
Add the new `accent_color` and `banner` fields. `accent_color` is an
integer representation of the RGB color while `banner` is a hash of the
user's banner image.

This is documented in the API docs:
<discord/discord-api-docs#3448>

Closes twilight-rs#1126.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants