Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for role icons #1823

Merged
merged 16 commits into from
Nov 23, 2021
Merged

Add support for role icons #1823

merged 16 commits into from
Nov 23, 2021

Conversation

sebm253
Copy link
Contributor

@sebm253 sebm253 commented Sep 15, 2021 •
edited
Loading

Pull Request Etiquette

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: _____

Closes Issue: NaN

Description

this PR adds support for role icons. see discord/discord-api-docs#3847

@DV8FromTheWorld
Copy link
Member

Looks pretty good to me. @MinnDevelopment?

@DV8FromTheWorld DV8FromTheWorld added type: feature Required for v4 LTS defines that something is slated for inclusion in the final v4 LTS builds size: small labels Sep 19, 2021
@MinnDevelopment
Copy link
Member

The docs PR is only a datamine PR for an experiment, so I would be against merging it at this time. See discord/discord-api-docs#3815

@sebm253
Copy link
Contributor Author

sebm253 commented Sep 19, 2021

that's one of the reasons this PR is a draft. I haven't tested it

@sebm253 @DV8FromTheWorld
Update src/main/java/net/dv8tion/jda/api/managers/RoleManager.java
fd016dd 
Co-authored-by: Austin Keener <keeneraustin@yahoo.com>
@DV8FromTheWorld
Copy link
Member

Okay, going to mark as freezer until the feature is no longer experimental.
Additionally, this PR will need to be redirected at v5 as we're closing down feature-additions on v4

@DV8FromTheWorld DV8FromTheWorld added status: freezer this is currently put on hold and removed Required for v4 LTS defines that something is slated for inclusion in the final v4 LTS builds labels Sep 19, 2021
@sebm253
Copy link
Contributor Author

sebm253 commented Sep 25, 2021

seems like the PR has been merged. I'll still wait until the feature is fully released to test it out properly

@sebm253 @MinnDevelopment
Update src/main/java/net/dv8tion/jda/internal/managers/RoleManagerImp…
63afea0 
…l.java

Co-authored-by: Florian Spieß <business@minnced.club>
@DV8FromTheWorld DV8FromTheWorld removed the status: freezer this is currently put on hold label Sep 26, 2021
@sebm253
Copy link
Contributor Author

sebm253 commented Sep 29, 2021

it'd be great if someone with access to role icons (owning a server with boost tier 2+) could test this PR because I don't have one. (I think the PR should be fine though)

@sebm253 sebm253 marked this pull request as ready for review September 29, 2021 21:47
@sebm253 sebm253 marked this pull request as draft September 30, 2021 08:46
@sebm253 sebm253 marked this pull request as ready for review September 30, 2021 10:53
@fangming-ning-sp
Copy link

When will this be available? I'm waiting for it

@DV8FromTheWorld
Copy link
Member

PR needs resolution of conversation between @caneleex and @MinnDevelopment before PR can be merged

MinnDevelopment
MinnDevelopment approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@MinnDevelopment MinnDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a small clarification in docs and then its good to go

src/main/java/net/dv8tion/jda/api/entities/Role.java Outdated Show resolved Hide resolved
src/main/java/net/dv8tion/jda/api/entities/Role.java Outdated Show resolved Hide resolved
sebm253 and others added 2 commits November 5, 2021 16:59
@sebm253 @MinnDevelopment
Apply suggestions from code review
32811bd 
Co-authored-by: Florian Spieß <business@minnced.club>
@sebm253
add missing ListenerAdapter methods
68ecbc4
@sebm253 sebm253 marked this pull request as draft November 7, 2021 23:36
@sebm253 sebm253 marked this pull request as ready for review November 8, 2021 13:15
@DV8FromTheWorld DV8FromTheWorld changed the title add support for role icons Add support for role icons Nov 23, 2021
@DV8FromTheWorld DV8FromTheWorld merged commit 7d17057 into discord-jda:development Nov 23, 2021
@sebm253 sebm253 mentioned this pull request Nov 24, 2021
Merged
6 tasks
@sebm253 sebm253 deleted the feature/role-icons branch November 24, 2021 17:26
This was referenced Jan 8, 2022
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gamebuster19901 Gamebuster19901 Gamebuster19901 left review comments

@DV8FromTheWorld DV8FromTheWorld DV8FromTheWorld approved these changes

@MinnDevelopment MinnDevelopment MinnDevelopment approved these changes

Assignees
No one assigned
Labels
type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sebm253 @DV8FromTheWorld @MinnDevelopment @fangming-ning-sp @Gamebuster19901