Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document ROLE_ICONS #3847

Merged
merged 2 commits into from
Sep 21, 2021
Merged

Document ROLE_ICONS #3847

merged 2 commits into from
Sep 21, 2021

Conversation

Lulalaby
Copy link
Contributor

This pr documents the feature ROLE_ICONS.

  • Add guild feature string
  • Add audit log keys
  • Add role properties
  • Document methods

Preview:
image
2021-09-21_22h46_02
2021-09-21_22h46_06

@Lulalaby Lulalaby closed this Sep 21, 2021
@Lulalaby Lulalaby deleted the feature/role-icons branch September 21, 2021 20:51
@Lulalaby Lulalaby restored the feature/role-icons branch September 21, 2021 20:51
@Lulalaby Lulalaby reopened this Sep 21, 2021
@Lulalaby
Copy link
Contributor Author

So now!

Copy link

@tkdaj tkdaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkdaj tkdaj merged commit 0f09124 into discord:master Sep 21, 2021
@Lulalaby Lulalaby deleted the feature/role-icons branch September 21, 2021 22:21
@Lulalaby
Copy link
Contributor Author

Thanks!

Nihlus added a commit to Remora/Remora.Discord that referenced this pull request Sep 23, 2021
Nihlus added a commit to Remora/Remora.Discord that referenced this pull request Sep 23, 2021
Nihlus added a commit to Remora/Remora.Discord that referenced this pull request Sep 23, 2021
izxxr added a commit to diskord-dev/diskord that referenced this pull request Sep 29, 2021
SQKo added a commit to SQKo/DiscordPHP that referenced this pull request Nov 3, 2021
davidcole1340 pushed a commit to discord-php/DiscordPHP that referenced this pull request Nov 4, 2021
* Add role icon in guild

discord/discord-api-docs#3847

* Add role icons feature in Guild.php

* Add missing unicode emoji in Updateable Attributes
SQKo added a commit to discord-php/DiscordPHP that referenced this pull request Jan 2, 2022
* Add role icon in guild

discord/discord-api-docs#3847

* Add role icons feature in Guild.php

* Add missing unicode emoji in Updateable Attributes

* Create Stage Instance Repository

Part of guild

* Add StageInstance Part & Events

* fix typo fillable

* Fix stage instance endpoint and typos

* Update src/Discord/Parts/Channel/StageInstance.php

Remove debugging

* remove null from getGuildAttribute

* remove guilds->push() from stage instance events

* Add stage instance const in audit log

* resolve conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants