Restructure message creation to handle a lack of guild_id #2039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ack of guild_id on messages.
3 tasks
src/main/java/net/dv8tion/jda/internal/entities/EntityBuilder.java
Outdated
Show resolved
Hide resolved
Comment on lines
+59
to
+61
| message = isGuild | ||
| ? jda.getEntityBuilder().createMessageGuildChannel(content, true) | ||
| : jda.getEntityBuilder().createMessagePrivateChannel(content, true); |
There was a problem hiding this comment.
Maybe add createMessage(content, isGuild, true)?
There was a problem hiding this comment.
Nah, I think the little bit of dupe we have that does this ternary is fine for now.
|
This PR should also add an implementation for |
This was referenced Feb 23, 2022
This was referenced Mar 3, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Closes Issue: NaN
Description
Discord does not provide
guild_idon message objects. We only ever get this property on messages when they come over the Websocket Gateway. However, historically, JDA has been written to expect it and we've gotten lucky that nothing broke.Recently we made a change to enforce nullability of
getUseronPrivateChanneland restructured some code to enable this along with filling in the data whenever we receive it, which happens to happen onMESSAGE_CREATE. This has revealed our erroneous reliance onguild_idin non-gateway situations.This PR restructured the EntityBuilder to enforce upon developers of JDA's internal code that they must either have a channel instance or define if the channel is guild or private when building a message. This makes explicit the methodologies used to determine
isGuildinstead of relying on a typically-missingguild_idjson property.