Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CommandInteractionPayload#getCommandString in autocomplete interactions #2659

Merged
merged 2 commits into from
Apr 21, 2024

Conversation

freya022
Copy link
Contributor

Pull Request Etiquette

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: _____

Closes Issue: NaN

Description

When printing a command string, in an autocomplete interaction, an IllegalStateException could occur when an entity is in that command, as Discord does not send resolved entities there

@MinnDevelopment MinnDevelopment merged commit 0ce30fd into discord-jda:master Apr 21, 2024
1 check passed
@freya022 freya022 deleted the fix/command-string branch April 21, 2024 10:13
BachErik added a commit to TwitchTube/DiscordBot that referenced this pull request Apr 21, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [net.dv8tion:JDA](https://togithub.com/DV8FromTheWorld/JDA) |
`5.0.0-beta.22` -> `5.0.0-beta.23` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/net.dv8tion:JDA/5.0.0-beta.23?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/net.dv8tion:JDA/5.0.0-beta.23?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/net.dv8tion:JDA/5.0.0-beta.22/5.0.0-beta.23?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/net.dv8tion:JDA/5.0.0-beta.22/5.0.0-beta.23?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>DV8FromTheWorld/JDA (net.dv8tion:JDA)</summary>

###
[`v5.0.0-beta.23`](https://togithub.com/discord-jda/JDA/releases/tag/v5.0.0-beta.23):
| Message Polls

### Overview

This release includes an updated README, please let us know if you spot
any issues with it!

##### Polls
([#&#8203;2649](https://togithub.com/DV8FromTheWorld/JDA/issues/2649))

Discord has recently released a new feature on their platform to start
and vote in polls. These polls can now be sent in messages:

```java
channel.sendMessage("Hello guys! Check my poll:")
  .setPoll(
    MessagePollData.builder("Which programming language is better?")
      .addAnswer("Java", Emoji.fromFormatted("<:java:1006323566314274856>"))
      .addAnswer("Kotlin", Emoji.fromFormatted("<:kotlin:295940257797636096>"))
      .build())
  .queue()
```

The poll automatically expires after a set duration, configurable in the
`MessagePollBuilder` using
[setDuration](https://docs.jda.wiki/net/dv8tion/jda/api/utils/messages/MessagePollBuilder.html#setDuration\(java.time.Duration\)).
A poll can also be ended manually using
[endPoll](https://docs.jda.wiki/net/dv8tion/jda/api/entities/Message.html#endPoll\(\))
or
[endPollById](https://docs.jda.wiki/net/dv8tion/jda/api/entities/channel/middleman/MessageChannel.html#endPollById\(java.lang.String\)).

You can check the poll votes on a message using the new
`Message#getPoll`:

```java
MessagePoll poll = message.getPoll();
for (MessagePoll.Answer answer : poll.getAnswers()) {
  System.out.printf("Poll Answer %s has %d votes\n", answer.getText(), answer.getVotes());
}
```

> \[!NOTE]
> The votes for polls are eventually consistent and need to be recounted
after the poll ends. You can check whether the votes are validated using
[MessagePoll#isFinalizedVotes](https://docs.jda.wiki/net/dv8tion/jda/api/entities/messages/MessagePoll.html#isFinalizedVotes\(\)).

#### New Features

- Add USER_MUST_BE_VERIFIED ErrorResponse by
[@&#8203;GitMilchi](https://togithub.com/GitMilchi) in
[discord-jda/JDA#2651
- Update permission enum by
[@&#8203;MinnDevelopment](https://togithub.com/MinnDevelopment) in
[discord-jda/JDA#2654
- Poll support by
[@&#8203;MinnDevelopment](https://togithub.com/MinnDevelopment) in
[discord-jda/JDA#2649

#### Changes

- Update dependencies and use version catalog by
[@&#8203;MinnDevelopment](https://togithub.com/MinnDevelopment) in
[discord-jda/JDA#2652

#### Bugs Fixes

- Fix `CommandInteractionPayload#getCommandString` in autocomplete
interactions by [@&#8203;freya022](https://togithub.com/freya022) in
[discord-jda/JDA#2659

**Full Changelog**:
discord-jda/JDA@v5.0.0-beta.22...v5.0.0-beta.23

### Installation

#### Gradle

```gradle
repositories {
    mavenCentral()
}
dependencies {
    implementation("net.dv8tion:JDA:5.0.0-beta.23")
}
```

#### Maven

```xml
<dependency>
    <groupId>net.dv8tion</groupId>
    <artifactId>JDA</artifactId>
    <version>5.0.0-beta.23</version> 
</dependency>
```

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/TwitchTube/DiscordBot).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=-->
BachErik added a commit to BachErik/Hypixel-Stats-generator that referenced this pull request Apr 21, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [net.dv8tion:JDA](https://togithub.com/DV8FromTheWorld/JDA) |
`5.0.0-beta.22` -> `5.0.0-beta.23` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/net.dv8tion:JDA/5.0.0-beta.23?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/net.dv8tion:JDA/5.0.0-beta.23?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/net.dv8tion:JDA/5.0.0-beta.22/5.0.0-beta.23?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/net.dv8tion:JDA/5.0.0-beta.22/5.0.0-beta.23?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>DV8FromTheWorld/JDA (net.dv8tion:JDA)</summary>

###
[`v5.0.0-beta.23`](https://togithub.com/discord-jda/JDA/releases/tag/v5.0.0-beta.23):
| Message Polls

### Overview

This release includes an updated README, please let us know if you spot
any issues with it!

##### Polls
([#&#8203;2649](https://togithub.com/DV8FromTheWorld/JDA/issues/2649))

Discord has recently released a new feature on their platform to start
and vote in polls. These polls can now be sent in messages:

```java
channel.sendMessage("Hello guys! Check my poll:")
  .setPoll(
    MessagePollData.builder("Which programming language is better?")
      .addAnswer("Java", Emoji.fromFormatted("<:java:1006323566314274856>"))
      .addAnswer("Kotlin", Emoji.fromFormatted("<:kotlin:295940257797636096>"))
      .build())
  .queue()
```

The poll automatically expires after a set duration, configurable in the
`MessagePollBuilder` using
[setDuration](https://docs.jda.wiki/net/dv8tion/jda/api/utils/messages/MessagePollBuilder.html#setDuration\(java.time.Duration\)).
A poll can also be ended manually using
[endPoll](https://docs.jda.wiki/net/dv8tion/jda/api/entities/Message.html#endPoll\(\))
or
[endPollById](https://docs.jda.wiki/net/dv8tion/jda/api/entities/channel/middleman/MessageChannel.html#endPollById\(java.lang.String\)).

You can check the poll votes on a message using the new
`Message#getPoll`:

```java
MessagePoll poll = message.getPoll();
for (MessagePoll.Answer answer : poll.getAnswers()) {
  System.out.printf("Poll Answer %s has %d votes\n", answer.getText(), answer.getVotes());
}
```

> \[!NOTE]
> The votes for polls are eventually consistent and need to be recounted
after the poll ends. You can check whether the votes are validated using
[MessagePoll#isFinalizedVotes](https://docs.jda.wiki/net/dv8tion/jda/api/entities/messages/MessagePoll.html#isFinalizedVotes\(\)).

#### New Features

- Add USER_MUST_BE_VERIFIED ErrorResponse by
[@&#8203;GitMilchi](https://togithub.com/GitMilchi) in
[discord-jda/JDA#2651
- Update permission enum by
[@&#8203;MinnDevelopment](https://togithub.com/MinnDevelopment) in
[discord-jda/JDA#2654
- Poll support by
[@&#8203;MinnDevelopment](https://togithub.com/MinnDevelopment) in
[discord-jda/JDA#2649

#### Changes

- Update dependencies and use version catalog by
[@&#8203;MinnDevelopment](https://togithub.com/MinnDevelopment) in
[discord-jda/JDA#2652

#### Bugs Fixes

- Fix `CommandInteractionPayload#getCommandString` in autocomplete
interactions by [@&#8203;freya022](https://togithub.com/freya022) in
[discord-jda/JDA#2659

**Full Changelog**:
discord-jda/JDA@v5.0.0-beta.22...v5.0.0-beta.23

### Installation

#### Gradle

```gradle
repositories {
    mavenCentral()
}
dependencies {
    implementation("net.dv8tion:JDA:5.0.0-beta.23")
}
```

#### Maven

```xml
<dependency>
    <groupId>net.dv8tion</groupId>
    <artifactId>JDA</artifactId>
    <version>5.0.0-beta.23</version> 
</dependency>
```

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/BachErik/Hypixel-Stats-generator).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
mergify bot pushed a commit to SvenKirschbaum/musikbot-client that referenced this pull request Apr 28, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|---|---|
| debian | final | digest | `3d5df92` -> `155280b` |  |  |  |  |
| rust | stage | digest | `6052afe` -> `8f891e6` |  |  |  |  |
| [net.dv8tion:JDA](https://togithub.com/DV8FromTheWorld/JDA) | compile | patch | `5.0.0-beta.22` -> `5.0.0-beta.23` | [![age](https://developer.mend.io/api/mc/badges/age/maven/net.dv8tion:JDA/5.0.0-beta.23?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/net.dv8tion:JDA/5.0.0-beta.23?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/net.dv8tion:JDA/5.0.0-beta.22/5.0.0-beta.23?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/net.dv8tion:JDA/5.0.0-beta.22/5.0.0-beta.23?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>DV8FromTheWorld/JDA (net.dv8tion:JDA)</summary>

### [`v5.0.0-beta.23`](https://togithub.com/discord-jda/JDA/releases/tag/v5.0.0-beta.23): | Message Polls

[Compare Source](https://togithub.com/DV8FromTheWorld/JDA/compare/v5.0.0-beta.22...v5.0.0-beta.23)

### Overview

This release includes an updated README, please let us know if you spot any issues with it!

##### Polls ([#&#8203;2649](https://togithub.com/DV8FromTheWorld/JDA/issues/2649))

Discord has recently released a new feature on their platform to start and vote in polls. These polls can now be sent in messages:

```java
channel.sendMessage("Hello guys! Check my poll:")
  .setPoll(
    MessagePollData.builder("Which programming language is better?")
      .addAnswer("Java", Emoji.fromFormatted("<:java:1006323566314274856>"))
      .addAnswer("Kotlin", Emoji.fromFormatted("<:kotlin:295940257797636096>"))
      .build())
  .queue()
```

The poll automatically expires after a set duration, configurable in the `MessagePollBuilder` using [setDuration](https://docs.jda.wiki/net/dv8tion/jda/api/utils/messages/MessagePollBuilder.html#setDuration\(java.time.Duration\)). A poll can also be ended manually using [endPoll](https://docs.jda.wiki/net/dv8tion/jda/api/entities/Message.html#endPoll\(\)) or [endPollById](https://docs.jda.wiki/net/dv8tion/jda/api/entities/channel/middleman/MessageChannel.html#endPollById\(java.lang.String\)).

You can check the poll votes on a message using the new `Message#getPoll`:

```java
MessagePoll poll = message.getPoll();
for (MessagePoll.Answer answer : poll.getAnswers()) {
  System.out.printf("Poll Answer %s has %d votes\n", answer.getText(), answer.getVotes());
}
```

> \[!NOTE]
> The votes for polls are eventually consistent and need to be recounted after the poll ends. You can check whether the votes are validated using [MessagePoll#isFinalizedVotes](https://docs.jda.wiki/net/dv8tion/jda/api/entities/messages/MessagePoll.html#isFinalizedVotes\(\)).

#### New Features

-   Add USER_MUST_BE_VERIFIED ErrorResponse by [@&#8203;GitMilchi](https://togithub.com/GitMilchi) in [discord-jda/JDA#2651
-   Update permission enum by [@&#8203;MinnDevelopment](https://togithub.com/MinnDevelopment) in [discord-jda/JDA#2654
-   Poll support by [@&#8203;MinnDevelopment](https://togithub.com/MinnDevelopment) in [discord-jda/JDA#2649

#### Changes

-   Update dependencies and use version catalog by [@&#8203;MinnDevelopment](https://togithub.com/MinnDevelopment) in [discord-jda/JDA#2652

#### Bugs Fixes

-   Fix `CommandInteractionPayload#getCommandString` in autocomplete interactions by [@&#8203;freya022](https://togithub.com/freya022) in [discord-jda/JDA#2659

**Full Changelog**: discord-jda/JDA@v5.0.0-beta.22...v5.0.0-beta.23

### Installation

#### Gradle

```gradle
repositories {
    mavenCentral()
}
dependencies {
    implementation("net.dv8tion:JDA:5.0.0-beta.23")
}
```

#### Maven

```xml
<dependency>
    <groupId>net.dv8tion</groupId>
    <artifactId>JDA</artifactId>
    <version>5.0.0-beta.23</version> 
</dependency>
```

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on sunday" in timezone Europe/Berlin, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/SvenKirschbaum/musikbot-client).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants