Add Docker Setup #13
Merged
Add Docker Setup #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shivansh-007
added
l: intermediate
p: high
Shivansh-007
force-pushed
the
setup-docker
branch
3 times, most recently
from
6e14341
to
a9b2a9d
Compare
onerandomusername
requested changes
Jul 28, 2021
Codecov Report
@@ Coverage Diff @@
## main #13 +/- ##
=======================================
Coverage 36.92% 36.92%
=======================================
Files 12 12
Lines 520 520
Branches 60 60
=======================================
Hits 192 192
Misses 323 323
Partials 5 5 Continue to review full report at Codecov.
|
Shivansh-007
force-pushed
the
setup-docker
branch
from
1c17980
to
51b95bd
Compare
|
Blocked by #32, since this adds features to the website. |
|
Sooo should I remove them from this PR or will you merge this and remove them from that PR? I had go with the second option 😉 |
onerandomusername
force-pushed
the
setup-docker
branch
3 times, most recently
from
87622ed
to
e44303e
Compare
onerandomusername
previously requested changes
Aug 8, 2021
Shivansh-007
force-pushed
the
setup-docker
branch
3 times, most recently
from
b784616
to
a266ae7
Compare
Shivansh-007
commented
Aug 8, 2021
Shivansh-007
force-pushed
the
setup-docker
branch
from
ecc8079
to
6882e36
Compare
Shivansh-007
added
the
skip changelog
------------ The Problems ------------ There are namely two problems which are being fixed in this issue: 1. `pyproject.toml` defines `modmail` package to be included, thus poetry searches for it but finds it be to be empty as originally we copied the poetry meta files only before installing and then copied rest of the package. 2. We are using pip to install poetry, we uses the new installer, the new installer has a known bug see python-poetry/poetry#3336 but the issue hasn't shown any acitivty since it has been opened unfortunately. ------------ The Solution ----------- 1. I have moved `COPY . .` to be ran before poetry install so poetry can find what the package to be included. 2. The only possible solution to this is to disable the old installer which was causing this bug for some reason.
Shivansh-007
force-pushed
the
setup-docker
branch
from
2f96f4f
to
880c1a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.