Skip to content

Add docker build to GHCR workflow #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 17, 2021
Merged

Add docker build to GHCR workflow #19

merged 3 commits into from
Aug 17, 2021

Conversation

@Shivansh-007
Copy link
Member

@Shivansh-007 Shivansh-007 commented Jun 8, 2021 •
edited by onerandomusername
Loading

Closes #15

Depends on #13

@Shivansh-007 Shivansh-007 added a: CI Continuous Integration and Continuous Deployment p: high High Priority s: needs review Ready for review and merge a: tools Development related to our toolchain (Docker, poetry, flake8) labels Jun 8, 2021
@onerandomusername onerandomusername added s: stalled Something is blocking further progress and removed s: needs review Ready for review and merge labels Jul 28, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2021 •
edited by codecov bot
Loading

Codecov Report

Merging #19 (3f76fc2) into main (bacc4be) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #19   +/-   ##
=======================================
  Coverage   36.92%   36.92%           
=======================================
  Files          12       12           
  Lines         520      520           
  Branches       60       60           
=======================================
  Hits          192      192           
  Misses        323      323           
  Partials        5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bacc4be...3f76fc2. Read the comment docs.

@onerandomusername onerandomusername added p: normal Normal Priority and removed p: high High Priority labels Aug 8, 2021
@onerandomusername onerandomusername force-pushed the docker-build-workflow branch 2 times, most recently from dfe928f to 8242c6a Compare August 8, 2021 15:31
@dpulls
Copy link

dpulls bot commented Aug 16, 2021

🎉 All dependencies have been resolved !

@onerandomusername onerandomusername added the skip changelog Skip the need for a changelog entry for a Pull Request label Aug 17, 2021
@onerandomusername onerandomusername merged commit f6f3eb3 into main Aug 17, 2021
onerandomusername
onerandomusername approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@onerandomusername onerandomusername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Since one of the workflows was renamed a while ago, I updated it in here.

@onerandomusername onerandomusername deleted the docker-build-workflow branch August 17, 2021 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@onerandomusername onerandomusername onerandomusername approved these changes

Assignees

@Shivansh-007 Shivansh-007

Labels

a: CI Continuous Integration and Continuous Deployment a: tools Development related to our toolchain (Docker, poetry, flake8) p: normal Normal Priority s: stalled Something is blocking further progress skip changelog Skip the need for a changelog entry for a Pull Request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI: Build to GHCR on push to main

4 participants

@Shivansh-007 @codecov-commenter @onerandomusername