Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document modals & input text #4143

Closed
wants to merge 38 commits into from
Closed

Document modals & input text #4143

wants to merge 38 commits into from

Conversation

Lulalaby
Copy link
Contributor

@Lulalaby Lulalaby commented Nov 22, 2021 •
edited
Loading

@Lulalaby Lulalaby changed the title ]Document modals Document modals Nov 22, 2021
Lulalaby and others added 4 commits November 22, 2021 21:47
@Lulalaby Lulalaby changed the title Document modals Document modals & input text Nov 22, 2021
joseywoermann
joseywoermann suggested changes Nov 22, 2021
View reviewed changes
docs/interactions/Message_Components.md Outdated Show resolved Hide resolved
docs/interactions/Message_Components.md Outdated Show resolved Hide resolved
@suneettipirneni suneettipirneni mentioned this pull request Nov 22, 2021
Merged
6 tasks
@queer queer mentioned this pull request Nov 22, 2021
Open
@Lulalaby Lulalaby mentioned this pull request Nov 23, 2021
Closed
izxxr
izxxr suggested changes Nov 23, 2021
View reviewed changes
docs/interactions/Message_Components.md Outdated Show resolved Hide resolved
@Lulalaby @izxxr
Update docs/interactions/Message_Components.md
f630494 
Co-authored-by: Izhar Ahmad <54180221+nerdguyahmad@users.noreply.github.com>
@msciotti msciotti added the not released This issue or PR is referencing a change that is not yet widely released and/or subject to change. label Nov 23, 2021
@suneettipirneni suneettipirneni mentioned this pull request Nov 24, 2021
Merged
@suneettipirneni
Copy link

suneettipirneni commented Nov 24, 2021 •
edited
Loading

Throwing my 2 cents in here, but doesn't it make sense for the sections to be renamed to just "Components" rather than "Message Components"? INPUT_TEXT can only be used in modals, and ACTION_ROW isn't exclusive to messages, it can be in modals as well.

joseywoermann
joseywoermann suggested changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@joseywoermann joseywoermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 minor grammar mistakes

docs/interactions/Message_Components.md Outdated Show resolved Hide resolved
docs/interactions/Receiving_and_Responding.md Outdated Show resolved Hide resolved
@Lulalaby @joseywoermann
Apply suggestions from code review
386bbbc 
Co-authored-by: Josey Wörmann <jcw05@gmx.de>
@l7ssha l7ssha mentioned this pull request Nov 24, 2021
Closed
@itohatweb itohatweb mentioned this pull request Nov 24, 2021
Merged
7 tasks
@Lulalaby @Victorsitou
Update docs/interactions/Message_Components.md
a9a8a6f 
Co-authored-by: Victor <67214928+Victorsitou@users.noreply.github.com>
@FedorLap2006 FedorLap2006 mentioned this pull request Dec 9, 2021
Merged
@itohatweb
Copy link
Contributor

There is now a required prop which defaults to true for input text also the min_length has been updated to default to 0.

@Lulalaby
Copy link
Contributor Author

@typpo could you take a quick look if the pr is correct for now?

@typpo
Copy link
Contributor

typpo commented Dec 15, 2021

Text input modals are still WIP and subject to change. While this is the case, the beta preview doc is the place to go for information on this potential feature while the API is not finalized. We'll have a look at this PR once it's ready to ship.

mafineeek
mafineeek approved these changes Dec 15, 2021
View reviewed changes
Copy link

@mafineeek mafineeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep nice

quinchs
quinchs reviewed Dec 15, 2021
View reviewed changes
docs/interactions/Receiving_and_Responding.md Outdated Show resolved Hide resolved
docs/interactions/Receiving_and_Responding.md Outdated Show resolved Hide resolved
docs/interactions/Message_Components.md Outdated Show resolved Hide resolved
docs/interactions/Message_Components.md Outdated Show resolved Hide resolved
Lulalaby and others added 2 commits December 16, 2021 05:09
@Lulalaby @quinchs
Apply suggestions from code review
de98e46 
Co-authored-by: Quin Lynch <49576606+quinchs@users.noreply.github.com>
@Lulalaby
Merge branch 'discord:master' into modals
62ca620
@Victorsitou Victorsitou mentioned this pull request Dec 17, 2021
Closed
@Lulalaby Lulalaby marked this pull request as ready for review December 30, 2021 22:06
Lulalaby and others added 2 commits December 31, 2021 19:31
@Lulalaby @Victorsitou
Update docs/interactions/Receiving_and_Responding.md
c4b6793 
Co-authored-by: Victor <67214928+Victorsitou@users.noreply.github.com>
@Lulalaby
Merge branch 'discord:master' into modals
21ffa26
@pascalharp pascalharp mentioned this pull request Jan 5, 2022
Merged
6 tasks
Lulalaby and others added 2 commits January 16, 2022 05:22
@Lulalaby @Victorsitou
Update docs/interactions/Receiving_and_Responding.md
0d248cf 
Co-authored-by: Victor <67214928+Victorsitou@users.noreply.github.com>
@Lulalaby
Merge branch 'discord:master' into modals
c0c3dfc
@devsnek devsnek closed this Jan 31, 2022
@night night removed the not released This issue or PR is referencing a change that is not yet widely released and/or subject to change. label Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JochCool JochCool JochCool left review comments

@quinchs quinchs quinchs left review comments

@sevenc-nanashi sevenc-nanashi sevenc-nanashi requested changes

@Victorsitou Victorsitou Victorsitou left review comments

@vvito7 vvito7 vvito7 left review comments

@izxxr izxxr izxxr requested changes

@joseywoermann joseywoermann joseywoermann requested changes

@ChickenDevs ChickenDevs ChickenDevs approved these changes

@mafineeek mafineeek mafineeek approved these changes

@arHSM arHSM arHSM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.