Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add attachment application command option type #4253

Merged
merged 3 commits into from Feb 8, 2022

Conversation

amitojsingh366
Copy link
Contributor

@amitojsingh366 amitojsingh366 commented Dec 17, 2021

it's the same pr as #4251 but reverts the package-lock.json change

I tried to set an option with type: 11 today right after the discord devs stage where they announced the new ATTACHMENT type for application commands, I assumed type: 11 is this new ATTACHMENT type and created this PR.

The data structure of the new interaction data object and how I found it is written in this gist

NOTE: this is my first time contributing to this project so if anything is wrong please do tell me

image

@amitojsingh366
Copy link
Contributor Author

@MinnDevelopment i messed that PR up lol but i think this one should be alright

@dolfies
Copy link

dolfies commented Dec 17, 2021

Just so you know, it usually isn't necessary to open a new PR because there are too many commits.

@amitojsingh366
Copy link
Contributor Author

Just so you know, it usually isn't necessary to open a new PR because there are too many commits.

yeah a few of my friends just told me that lol. should have consulted them before doing this

@amitojsingh366 amitojsingh366 changed the title add attachment application command option type WIP: add attachment application command option type Dec 18, 2021
@amitojsingh366 amitojsingh366 changed the title WIP: add attachment application command option type add attachment application command option type Dec 18, 2021
@MinnDevelopment
Copy link
Contributor

For how long are attachments from command options available on the CDN? I think if there is a time window, that should be mentioned in the docs.

@amitojsingh366
Copy link
Contributor Author

For how long are attachments from command options available on the CDN? I think if there is a time window, that should be mentioned in the docs.

This is a good question however I am unsure about this myself as I have not been able to successfully send an attachment due to this feature not being implemented in the discord client yet. Hopefully a staff member can enlighten us?

@typpo typpo added the not released This issue or PR is referencing a change that is not yet widely released and/or subject to change. label Dec 21, 2021
@IanMitchell IanMitchell self-requested a review February 8, 2022 23:25
@IanMitchell IanMitchell merged commit b268fe7 into discord:master Feb 8, 2022
@IanMitchell
Copy link
Contributor

Thanks for doing this, much appreciated!

@amitojsingh366
Copy link
Contributor Author

Thanks for doing this, much appreciated!

My pleasure ☺️

@night night removed the not released This issue or PR is referencing a change that is not yet widely released and/or subject to change. label Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants