Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: attachment application command option type #7200

Merged
merged 12 commits into from
Feb 14, 2022
Merged

feat: attachment application command option type #7200

merged 12 commits into from
Feb 14, 2022

Conversation

amitojsingh366
Copy link
Contributor

@amitojsingh366 amitojsingh366 commented Jan 7, 2022 •
edited by kyranet
Loading

Please describe the changes this PR makes and why it should be merged:
Adds the new ATTACHMENT command option type and also adds patching for filename in MessageAttachment#_patch

Status and versioning classification:
This PR relies on This PR relies on discordjs/discord-api-types#272 and discord/discord-api-docs#4253

@amitojsingh366 amitojsingh366 mentioned this pull request Jan 8, 2022
Closed
8 tasks
@iCrawl iCrawl changed the title feat(discord.js): attachment application command option type feat: attachment application command option type Jan 8, 2022
@iCrawl iCrawl added this to the discord.js v14 milestone Jan 8, 2022
@SocketSomeone SocketSomeone mentioned this pull request Jan 9, 2022
Closed
1 task
@xhyrom xhyrom mentioned this pull request Jan 9, 2022
Closed
1 task
@iCrawl
Copy link
Member

iCrawl commented Jan 12, 2022

This needs a rebase.

@amitojsingh366
Copy link
Contributor Author

amitojsingh366 commented Jan 12, 2022 •
edited
Loading

This needs a rebase.

👍

@kyranet kyranet requested a review from iCrawl January 12, 2022 19:26
@xhyrom xhyrom mentioned this pull request Jan 25, 2022
Merged
2 tasks
almeidx
almeidx reviewed Jan 29, 2022
View reviewed changes
Copy link
Member

@almeidx almeidx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The typings need to be updated to conform with #7290

@Smidul
Copy link

Smidul commented Feb 9, 2022

Both upstream PRs were merged 🍫

@monbrey monbrey mentioned this pull request Feb 10, 2022
Merged
monbrey
monbrey reviewed Feb 10, 2022
View reviewed changes
packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved
packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved
@Mysterious-Dev
Copy link

All waiting PR are merged

almeidx
almeidx requested changes Feb 13, 2022
View reviewed changes
Copy link
Member

@almeidx almeidx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The typings file has lots of unrelated style changes

packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved
@iCrawl iCrawl merged commit 0034396 into discordjs:main Feb 14, 2022
@KhafraDev KhafraDev mentioned this pull request Feb 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almeidx almeidx almeidx requested changes

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@monbrey monbrey Awaiting requested review from monbrey

Assignees
No one assigned
Labels
api support discord packages:discord.js semver:minor
Projects
discord.js
Archived in project
Milestone
discord.js v14
Development

Successfully merging this pull request may close these issues.
9 participants
@amitojsingh366 @iCrawl @Smidul @Mysterious-Dev @monbrey @vladfrangu @kyranet @SpaceEEC @almeidx