Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the ability to use dynamic images for rpc activities #4317

Merged
merged 3 commits into from
Jan 19, 2022

Conversation

LostLuma
Copy link
Contributor

@LostLuma LostLuma commented Jan 7, 2022

No description provided.

@advaith1
Copy link
Contributor

advaith1 commented Jan 8, 2022

might be good to also document the prefixes in the received values, and how to handle them? (mp:, spotify:, youtube:, twitch:)

https://github.com/discordjs/discord.js/blob/5be347e171009e83e4f9c5fef0c7c17f74a800a1/packages/discord.js/src/structures/Presence.js#L376-L392

@LostLuma
Copy link
Contributor Author

LostLuma commented Jan 8, 2022

I'm not opposed to this, should I create a table below this one or add to the image formatting table on the reference page?

@arHSM
Copy link
Contributor

arHSM commented Jan 8, 2022

should I create a table below this one or add to the image formatting table on the reference page?

I would prefer the reference page.

@advaith1
Copy link
Contributor

advaith1 commented Jan 8, 2022

imo it should go here (the gateway page) as they aren't CDN endpoints and they're only in the activity object

@arHSM
Copy link
Contributor

arHSM commented Jan 8, 2022

yeah i had the same thought too

@night night merged commit 0a91423 into discord:master Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants