Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos in Voice.md #4565

Merged
merged 1 commit into from
Mar 9, 2022
Merged

fix typos in Voice.md #4565

merged 1 commit into from
Mar 9, 2022

Conversation

jonobarel
Copy link
Contributor

move question mark from the wrong column.

move question mark from the wrong column.
@lukellmann
Copy link
Contributor

This seems to be at least partially wrong for request_to_speak_timestamp: we received the following JSON:

"voice_states": [
  {
    "user_id": "...",
    "suppress": false,
    "session_id": "...",
    "self_video": false,
    "self_mute": true,
    "self_deaf": false,
    "request_to_speak_timestamp": null,
    "mute": false,
    "deaf": false,
    "channel_id": "..."
  }
],

So I can confirm that request_to_speak_timestamp is nullable, I don't know if it is actually optional.

I can neither confirm nor deny that channel_id is optional or nullable.

@lukellmann
Copy link
Contributor

Don't get me wrong, I don't want to insinuate anything, but were you aware of what the question marks stand for @jonobarel? (The title and the description could indicate that you weren't, since they don't mention anything about optional or nullable.)

Here is what they stand for:
https://discord.com/developers/docs/reference#nullable-and-optional-resource-fields

typpo added a commit that referenced this pull request Mar 12, 2022
typpo added a commit that referenced this pull request Mar 12, 2022
@jonobarel
Copy link
Contributor Author

@lukellmann Actually I was not aware. I tried to look for it in the documentation and didn't find it so I guess that one's on me :)
Thanks for clarifying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants