Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes of latest docs commits #561

Merged
merged 8 commits into from
Mar 11, 2022
Merged

Changes of latest docs commits #561

merged 8 commits into from
Mar 11, 2022

Conversation

lukellmann
Copy link
Member

@lukellmann lukellmann commented Mar 10, 2022 •
edited
Loading

Discord made a lot of commits to their Docs today, this PR brings the corresponding changes to Kord.

Changes for discord/discord-api-docs#4564 committed in discord/discord-api-docs@074e930

  • RoleCreateBuilder / GuildRoleCreateRequest: nullable icon and unicodeEmoji
  • RoleModifyBuilder / GuildRoleModifyRequest: change all parameters to be optional and nullable
  • Guild Scheduled Event: add image, optional and nullable entityMetadata and description in modify

Changes for discord/discord-api-docs#4551 committed in discord/discord-api-docs@c5b0eab

  • SelectMenuBuilder: update docs about placeholder length

Changes for discord/discord-api-docs#4565 committed in discord/discord-api-docs@d7b47a3

  • VoiceState: optional instead of nullable channelId and requestToSpeakTimestamp, make requestToSpeakTimestamp Instant
  • fix isSelfSteaming typo

Changes for discord/discord-api-docs#4533 committed in discord/discord-api-docs@19ca14c

  • rename JsonErrorCode.CannotSendMessagesInVoiceChannel to JsonErrorCode.CannotSendMessagesInNonTextChannel

Changes for discord/discord-api-docs#4583 committed in discord/discord-api-docs@42a20ae

  • Stage Instance: add guildScheduledEventId

@lukellmann lukellmann marked this pull request as ready for review March 10, 2022 23:24
@lukellmann
Copy link
Member Author

this is now ready

@HopeBaron HopeBaron merged commit c0bf25c into kordlib:0.8.x Mar 11, 2022
@lukellmann lukellmann deleted the changes/latest-docs-commits branch March 11, 2022 18:49
@lukellmann lukellmann mentioned this pull request Mar 11, 2022
Merged
lukellmann added a commit that referenced this pull request Mar 12, 2022
@lukellmann
Fix oversights in #561 (#565)
0744e13 
* DiscordVoiceState.channelId is now optional instead of nullable

* remove Deprecation for GuildRoleCreateRequest.id

* docs
@lukellmann lukellmann mentioned this pull request Mar 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lukellmann @HopeBaron