Add support for macOS on Apple Silicon #164
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o can locate them
|
@skidder 👋 A gentle ping. If I can do anything to make this easier to review and incorporate, let me know. |
|
hi, any updates on this PR? |
Waldeedle
reviewed
Sep 20, 2024
|
|
||
| # TODO: Fix this in the upstream deps repo | ||
| cd "$SRCDIR" | ||
| wget -q -O giflib-5.2.2.tar.gz https://sourceforge.net/projects/giflib/files/giflib-5.2.2.tar.gz/download |
There was a problem hiding this comment.
seems like 5.2.2 has been added in the upstream deps repo already and that discord has added a patch for giflib as well
There was a problem hiding this comment.
@remiolivier-discord I noticed you updated the deps repo, could you also update the build scripts in the main branch for lilliput? 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #157, this PR contributes the following:
I tried to break things up into small commits for easier review. The last ~5 commits are the key changes -- adding arm64 support, adding CI, and rebuilding the dependencies. The rest are fixes for the build.
If you'd like me to make a separate PR for the CI stuff, I'm happy to do that. There's a test run of the main CI workflow here and one for the dependency workflow here.
Happy to talk through any questions or concerns. Thanks!
Resolves #157. Resolves #138. Resolves #139.