11.18.1 discord 1 merge master new arch #27

donaldchen · 2023-07-26T22:44:00Z

This PR merges the new-arch changes from master into 11.18.1-discord-1.

I did one round of resolving conflicts, but I need to test this, still.

## [11.18.2](react-native-webview/react-native-webview@v11.18.1...v11.18.2) (2022-04-27) ### Bug Fixes * **windows:** update Getting Started information for Windows ([92ba4fa](react-native-webview@92ba4fa))

…-native-webview#2444)

…ct-native-webview#2489)

# [11.19.0](react-native-webview/react-native-webview@v11.18.2...v11.19.0) (2022-05-19) ### Features * **android:** Adding downloadMessage as a prop for localization ([react-native-webview#2489](react-native-webview#2489)) ([c3f73fe](react-native-webview@c3f73fe))

…ative-webview#2474)

@matinzd

…iew#2410 by @matinzd)

@matinzd

# [11.20.0](react-native-webview/react-native-webview@v11.19.0...v11.20.0) (2022-05-23) ### Features * **ios:** adds allowsAirPlayForMediaPlayback prop ([react-native-webview#2410](react-native-webview#2410) by [@matinzd](https://github.com/matinzd)) ([eb4e923](react-native-webview@eb4e923))

## [11.20.1](react-native-webview/react-native-webview@v11.20.0...v11.20.1) (2022-05-28) ### Bug Fixes * **ios:** support requestFocus ([react-native-webview#2501](react-native-webview#2501)) ([41ae896](react-native-webview@41ae896))

* feat: improve dummy WebView * Update WebView.tsx Co-authored-by: Thibault Malbranche <malbranche.thibault@gmail.com>

# [11.21.0](react-native-webview/react-native-webview@v11.20.1...v11.21.0) (2022-05-29) ### Features * improve dummy WebView ([react-native-webview#2509](react-native-webview#2509)) ([2e79a03](react-native-webview@2e79a03))

…ew#2512)

…bview#2517)

## [11.21.1](react-native-webview/react-native-webview@v11.21.0...v11.21.1) (2022-05-31) ### Bug Fixes * **windows:** don't build WebView2 unless on WinUI 3 ([react-native-webview#2517](react-native-webview#2517)) ([0571062](react-native-webview@0571062))

…native-webview#2531) * Revert "fix(windows): don't build WebView2 unless on WinUI 3 (react-native-webview#2517)" This reverts commit 0571062. * just remove the USE_WINUI3 check

## [11.21.2](react-native-webview/react-native-webview@v11.21.1...v11.21.2) (2022-06-07) ### Reverts * Revert "fix(windows): don't build WebView2 unless on WinUI 3" (react-native-webview#2531) ([ed3d6ed](react-native-webview@ed3d6ed)), closes [react-native-webview#2531](react-native-webview#2531) [react-native-webview#2517](react-native-webview#2517)

…genNativeCommands (react-native-webview#2508) * wip * wip * Update RNCWebViewManager.java * Shared stuff with iOS * bump stuff * wip * fix(windows): don't build WebView2 unless on WinUI 3 (react-native-webview#2518) Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com> * wip * Revert 2517 tido/fix webview2 build (react-native-webview#2532) * Revert "fix(windows): don't build WebView2 unless on WinUI 3 (react-native-webview#2517)" This reverts commit 0571062. * just remove the USE_WINUI3 check Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com> * Create ExperimentalFeatures.props Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com> Co-authored-by: Jamon Holmgren <jamonholmgren@gmail.com>

# [11.22.0](react-native-webview/react-native-webview@v11.21.2...v11.22.0) (2022-06-09) ### Features * **refactor:** remove findnodehandle, use function components & codegenNativeCommands ([react-native-webview#2508](react-native-webview#2508)) ([6b8e4f3](react-native-webview@6b8e4f3)), closes [react-native-webview#2518](react-native-webview#2518) [react-native-webview#2532](react-native-webview#2532) [react-native-webview#2517](react-native-webview#2517)

…native-webview#2534) Xcode: Editor → Structure → Re-indent

Fixes react-native-webview#2538

## [11.22.1](react-native-webview/react-native-webview@v11.22.0...v11.22.1) (2022-06-10) ### Bug Fixes * **android:** fixed issue with refactor ([ff08b11](react-native-webview@ff08b11)), closes [react-native-webview#2538](react-native-webview#2538)

…ct-native-webview#2432)

## [11.22.2](react-native-webview/react-native-webview@v11.22.1...v11.22.2) (2022-06-12) ### Bug Fixes * Don't crash if trying to download "invalid" URIs on Android ([react-native-webview#2432](react-native-webview#2432)) ([c424a49](react-native-webview@c424a49))

…bview#2537) * Implement PostMessage / OnMessage * Fix Stop Loading * Address Feedback * Address Feedback

Co-authored-by: Chiara Mooney <34109996+chiaramooney@users.noreply.github.com>

* fix: add properties for ios WKWebView configuration * Update WebView.ios.tsx * Update WebView.macos.tsx Co-authored-by: Thibault Malbranche <malbranche.thibault@gmail.com>

…ve-webview#2897) * [windows] Support headers and cookies in source prop * minor fixes

# [12.2.0](react-native-webview/react-native-webview@v12.1.0...v12.2.0) (2023-06-01) ### Features * **windows:** Support headers and cookies in source prop ([react-native-webview#2897](react-native-webview#2897)) ([1851ead](react-native-webview@1851ead))

… some OEMs (react-native-webview#2952)" This reverts commit 75e7801.

## [12.2.1](react-native-webview/react-native-webview@v12.2.0...v12.2.1) (2023-06-10) ### Bug Fixes * Revert "Missing android.support.FILE_PROVIDER_PATHS meta-data on some OEMs ([react-native-webview#2952](react-native-webview#2952))" ([e17a79b](react-native-webview@e17a79b))

…iew#2993) * Update RNCWebView.java * Update RNCWebView.java * wip * wip * fix build on latest xcode * add example + fix a few things * Update RNCWebViewImpl.m * fix macOS build

# [12.3.0](react-native-webview/react-native-webview@v12.2.1...v12.3.0) (2023-06-10) ### Features * custom action menu on android + improved iOS ([react-native-webview#2993](react-native-webview#2993)) ([f2aef66](react-native-webview@f2aef66))

* feat: add webviewDebuggingEnabled prop & Android implementation fix: use static RNCWebView.setWebContentsDebuggingEnabled * feat: add iOS webviewDebuggingEnabled prop * chore: remove "link generted with jump2header" comments * chore: add missing props-index links in Reference.md * feat: add webviewDebuggingEnabled reference docs * fix: surround inspectable code blocks with compiler preprocessor to include only on appropriate versions  --------- Co-authored-by: Tom Bury <tom.bury@twipemobile.com>

# [12.4.0](react-native-webview/react-native-webview@v12.3.0...v12.4.0) (2023-06-10) ### Features * debugging enabled prop ([react-native-webview#2937](react-native-webview#2937)) ([f9a5277](react-native-webview@f9a5277))

) BREAKING CHANGE: This affects an existing loading behavior so we marked it as breaking, just in case Co-authored-by: Peter Lazar <peter.lazar@limehome.de> Co-authored-by: Thibault Malbranche <thibault@brigad.co>

# [13.0.0](react-native-webview/react-native-webview@v12.4.0...v13.0.0) (2023-06-10) ### Features * Allow webview to load in background tab ([react-native-webview#2930](react-native-webview#2930)) ([40c9807](react-native-webview@40c9807)) ### BREAKING CHANGES * This affects an existing loading behavior so we marked it as breaking, just in case Co-authored-by: Peter Lazar <peter.lazar@limehome.de> Co-authored-by: Thibault Malbranche <thibault@brigad.co>

…e-webview#2801) (react-native-webview#2994) * feat: fraudulentWebsiteWarningEnabled * chore: test new arch on CI # Conflicts: # docs/Reference.md * fix: missing type * feat: add ios13 check * Update src/WebViewTypes.ts Co-authored-by: Caleb Clarke <TheAlmightyBob@users.noreply.github.com> * Update docs/Reference.md Co-authored-by: Caleb Clarke <TheAlmightyBob@users.noreply.github.com> * implem adaptation * Update ios-ci.yml * Update ios-ci.yml * Update android-ci.yml * Update ios-ci.yml * fix android new arch * Update ios-ci.yml --------- Co-authored-by: sunnylqm <sunnylqm@gmail.com> Co-authored-by: Caleb Clarke <TheAlmightyBob@users.noreply.github.com>

# [13.1.0](react-native-webview/react-native-webview@v13.0.0...v13.1.0) (2023-06-10) ### Features * **iOS:** fraudulent website warning setting (previously [react-native-webview#2801](react-native-webview#2801)) ([react-native-webview#2994](react-native-webview#2994)) ([6d185e6](react-native-webview@6d185e6))

…webview#2954) Co-authored-by: Thibault Malbranche <thibault@brigad.co>

# [13.2.0](react-native-webview/react-native-webview@v13.1.0...v13.2.0) (2023-06-11) ### Features * **android:** Add support for the `capture` attribute ([react-native-webview#2954](react-native-webview#2954)) ([966221e](react-native-webview@966221e))

## [13.2.1](react-native-webview/react-native-webview@v13.2.0...v13.2.1) (2023-06-12) ### Bug Fixes * build on 0.72 new arch ([react-native-webview#2997](react-native-webview#2997)) ([7ceeb2f](react-native-webview@7ceeb2f))

…e-webview#3006) Co-authored-by: Vahagn Nikoghosyan <vahagnn@meta.com>

## [13.2.2](react-native-webview/react-native-webview@v13.2.1...v13.2.2) (2023-06-14) ### Bug Fixes * **macOS:** address regression due to didMoveToSuperview ([react-native-webview#3006](react-native-webview#3006)) ([41576ca](react-native-webview@41576ca))

donaldchen · 2023-07-26T22:45:48Z

src/RNCWebViewNativeComponent.ts

+});
+
+export default codegenNativeComponent<NativeProps>(
+  'RNCWebView'


On iOS, the parent component is RNCWebView, and its child is WKWebView. On Android, it used to be just one RNCWebView which extended the native Android WebView. Now, the parent component is RNCWebViewContainer, and its child is the old RNCWebView.

@joemun , do you know if it's okay for this to say RNCWebView even though the native component is RNCWebViewContainer on Android:

This value needs to match the name specified in the view manager (RNCWebViewModuleImpl.NAME).

On iOS, it needs to match the exported name (ie. RCT_EXPORT_MODULE in RNCWebViewManager.mm), which also appears to be good.

Thanks!

This value needs to match the name specified in the view manager (RNCWebViewModuleImpl.NAME)

To clarify, can the name say RNCWebView on Android in the view manager even if the native component that maps 1:1 to the react component is actually named RNCWebViewContainer? Also, I'm assuming that on Android and iOS, the name (in the view manager on Android and the exported name from RCT_EXPORT_MODULE in RNCWebViewManager.mm) have to be the same. Is that correct?

On the TSX side, it's referencing the RNCWebView native component, which returns an instance of the RNCWebViewContainer. So I think this is fine. The name here is supposed to align with the view manager.

https://github.com/discord/react-native-webview/pull/27/files#diff-8576be466ba1cccbe7c11ba839c58655910cfcea677ad1de381d2a5194089ad8R16

Also, I'm assuming that on Android and iOS, the name (in the view manager on Android and the exported name from RCT_EXPORT_MODULE in RNCWebViewManager.mm) have to be the same. Is that correct?

Yep

…native view

github-actions · 2024-01-15T00:11:48Z

Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

asklar and others added 30 commits April 26, 2022 12:19

chore(windows): fix noisy warning (react-native-webview#2460)

80d03e0

Fix Break From Pkg Ref Changes (react-native-webview#2459)

603c751

fix(windows): update Getting Started information for Windows

92ba4fa

chore(release): 11.18.2 [skip ci]

f7cd6c4

## [11.18.2](react-native-webview/react-native-webview@v11.18.1...v11.18.2) (2022-04-27) ### Bug Fixes * **windows:** update Getting Started information for Windows ([92ba4fa](react-native-webview@92ba4fa))

chore(docs): fix ex, add js ex, add line, add closing backtick (react…

a36394f

…-native-webview#2444)

feat(android): Adding downloadMessage as a prop for localization (rea…

c3f73fe

…ct-native-webview#2489)

chore(docs): Update Portuguese reference (add clearCache ex) (react-n…

4cf05fc

…ative-webview#2474)

feat(ios): adds allowsAirPlayForMediaPlayback prop (react-native-webv…

eb4e923

…iew#2410 by @matinzd)

fix(ios): support requestFocus (react-native-webview#2501)

41ae896

chore(release): 11.20.1 [skip ci]

5ffa17f

## [11.20.1](react-native-webview/react-native-webview@v11.20.0...v11.20.1) (2022-05-28) ### Bug Fixes * **ios:** support requestFocus ([react-native-webview#2501](react-native-webview#2501)) ([41ae896](react-native-webview@41ae896))

chore(readme): update readme

5067dc2

feat: improve dummy WebView (react-native-webview#2509)

2e79a03

* feat: improve dummy WebView * Update WebView.tsx Co-authored-by: Thibault Malbranche <malbranche.thibault@gmail.com>

chore(release): 11.21.0 [skip ci]

8611237

# [11.21.0](react-native-webview/react-native-webview@v11.20.1...v11.21.0) (2022-05-29) ### Features * improve dummy WebView ([react-native-webview#2509](react-native-webview#2509)) ([2e79a03](react-native-webview@2e79a03))

chore: update Expo is supported platforms section (react-native-webvi…

dc050b5

…ew#2512)

fix(windows): don't build WebView2 unless on WinUI 3 (react-native-we…

0571062

…bview#2517)

Revert "fix(windows): don't build WebView2 unless on WinUI 3" (react-…

ed3d6ed

…native-webview#2531) * Revert "fix(windows): don't build WebView2 unless on WinUI 3 (react-native-webview#2517)" This reverts commit 0571062. * just remove the USE_WINUI3 check

chore(formatting): Re-indent the Objective-C code to 2 spaces (react-…

a68df85

…native-webview#2534) Xcode: Editor → Structure → Re-indent

fix(android): fixed issue with refactor

ff08b11

Fixes react-native-webview#2538

fix: Don't crash if trying to download "invalid" URIs on Android (rea…

c424a49

…ct-native-webview#2432)

Implement postMessage/onMessage for Windows WebView2 (react-native-we…

4b1f379

…bview#2537) * Implement PostMessage / OnMessage * Fix Stop Loading * Address Feedback * Address Feedback

Change WindowsTargetPlatformVersion to 10.0 (react-native-webview#2521)

53ff8fb

Co-authored-by: Chiara Mooney <34109996+chiaramooney@users.noreply.github.com>

fix(iOS/macOS): re-added missing properties due to hooks refactor

453d22d

* fix: add properties for ios WKWebView configuration * Update WebView.ios.tsx * Update WebView.macos.tsx Co-authored-by: Thibault Malbranche <malbranche.thibault@gmail.com>

vahagnni and others added 19 commits June 1, 2023 22:57

feat(windows): Support headers and cookies in source prop (react-nati…

1851ead

…ve-webview#2897) * [windows] Support headers and cookies in source prop * minor fixes

fix: Revert "Missing android.support.FILE_PROVIDER_PATHS meta-data on…

e17a79b

… some OEMs (react-native-webview#2952)" This reverts commit 75e7801.

feat: custom action menu on android + improved iOS (react-native-webv…

f2aef66

…iew#2993) * Update RNCWebView.java * Update RNCWebView.java * wip * wip * fix build on latest xcode * add example + fix a few things * Update RNCWebViewImpl.m * fix macOS build

chore(release): 12.3.0 [skip ci]

c6125b0

# [12.3.0](react-native-webview/react-native-webview@v12.2.1...v12.3.0) (2023-06-10) ### Features * custom action menu on android + improved iOS ([react-native-webview#2993](react-native-webview#2993)) ([f2aef66](react-native-webview@f2aef66))

chore(release): 12.4.0 [skip ci]

79a9cb6

# [12.4.0](react-native-webview/react-native-webview@v12.3.0...v12.4.0) (2023-06-10) ### Features * debugging enabled prop ([react-native-webview#2937](react-native-webview#2937)) ([f9a5277](react-native-webview@f9a5277))

feat: Allow webview to load in background tab (react-native-webview#2930

40c9807

) BREAKING CHANGE: This affects an existing loading behavior so we marked it as breaking, just in case Co-authored-by: Peter Lazar <peter.lazar@limehome.de> Co-authored-by: Thibault Malbranche <thibault@brigad.co>

feat(android): Add support for the capture attribute (react-native-…

966221e

…webview#2954) Co-authored-by: Thibault Malbranche <thibault@brigad.co>

fix: build on 0.72 new arch (react-native-webview#2997)

7ceeb2f

chore(release): 13.2.1 [skip ci]

4a7e7cd

## [13.2.1](react-native-webview/react-native-webview@v13.2.0...v13.2.1) (2023-06-12) ### Bug Fixes * build on 0.72 new arch ([react-native-webview#2997](react-native-webview#2997)) ([7ceeb2f](react-native-webview@7ceeb2f))

fix(macOS): address regression due to didMoveToSuperview (react-nativ…

41576ca

…e-webview#3006) Co-authored-by: Vahagn Nikoghosyan <vahagnn@meta.com>

Merge branch 'master' into 11.18.1-discord-1-merge-master-new-arch

103e0fd

donaldchen commented Jul 26, 2023

View reviewed changes

donaldchen added 6 commits August 7, 2023 13:39

fix Android build errors

3a091aa

fix iOS build errors

d91b18a

fix iOS build errors

38f543f

more Android fixes. add some temporary parent node logic

477ba2b

[ios] pass web view key and temporary parent node tags from props to …

e47e34c

…native view

cleanup

8d41b37

donaldchen mentioned this pull request Sep 12, 2023

support message passing and keeping native WebView in memory when react component is unmounted react-native-webview/react-native-webview#2469

Open

github-actions bot added the Stale label Jan 15, 2024

donaldchen removed the Stale label Jan 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

11.18.1 discord 1 merge master new arch #27

11.18.1 discord 1 merge master new arch #27

donaldchen commented Jul 26, 2023 •

edited

donaldchen Jul 26, 2023

joemun Jul 27, 2023 •

edited

donaldchen Jul 27, 2023

joemun Jul 27, 2023

joemun Jul 27, 2023

github-actions bot commented Jan 15, 2024

11.18.1 discord 1 merge master new arch #27

Are you sure you want to change the base?

11.18.1 discord 1 merge master new arch #27

Conversation

donaldchen commented Jul 26, 2023 • edited

donaldchen Jul 26, 2023

Choose a reason for hiding this comment

joemun Jul 27, 2023 • edited

Choose a reason for hiding this comment

donaldchen Jul 27, 2023

Choose a reason for hiding this comment

joemun Jul 27, 2023

Choose a reason for hiding this comment

joemun Jul 27, 2023

Choose a reason for hiding this comment

github-actions bot commented Jan 15, 2024

donaldchen commented Jul 26, 2023 •

edited

joemun Jul 27, 2023 •

edited