Use a logger instead of puts

[meew0]

No description provided.

[RX14]

Make sure to log raw message data from Gateway and REST to make generating error logs easier.

[RX14]

I think maybe we should be a little more verbose on debug. For example, we don't log REST requests, and logging of gateway messages is very inconsistent. I would like us to be able to reconstruct exactly what's happening on gateway and REST from a debug log.

[colinrioux]

That's true, it would be more helpful.

However, that being said, this section from client.cr

rescue ex : JSON::ParseException
      LOGGER.error <<-LOG
        An exception occurred during message parsing! Please report this.
        #{ex}
        (pertaining to previous exception) Raised with packet:
        #{message}
        LOG
    rescue ex
      LOGGER.error <<-LOG
        A miscellaneous exception occurred during message handling.
        #{ex}
        LOG
    end
end

When logged using the logger or the many puts statements, can be extremely long for long servers (one being Discord Bots). It's not really an issue, but it would be nice to limit the log to the best that we can.

[RX14]

@colinrioux if those errors are being gnerated there's either a bug in your code or a bug in discordcr and they should be reported. That's why it doesn't matter that they're long. They should be log so you notice them and report them... like it asks you.

Have you reported them?

[meew0]

Closing this for now as the logger is implemented; please make further issues if there are still problems

[RX14]

See #6 (comment) for why this was left open

[meew0]

Yes, but that is not what this issue is about ("Use a logger instead of puts"). Further logging advances could be in their own issue

[RX14]

ok