Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes home system and faction fields from the crew records program as they were always showing up empty #7642

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

Iglpigl
Copy link
Contributor

@Iglpigl Iglpigl commented Sep 30, 2022

About The Pull Request

Removes home system and faction fields from the crew records program as they were always showing up empty and Nanako ain't returning.

Why It's Good For The Game

Empty fields bad.

Changelog

🆑
del: Removed two fields from the crew records console which were empty anyways
/:cl:

@SirRichardFrancis
Copy link
Member

Might as well merge those to hold a "background" field from character setup, or whatever it's called.
It's both place of origin and faction affiliation to some degree.

@Humonitarian
Copy link
Contributor

Humonitarian commented Sep 30, 2022

Might as well merge those to hold a "background" field from character setup, or whatever it's called. It's both place of origin and faction affiliation to some degree.

Be from First Fleet
Working as a Moebious Scientist
"Hello I am a Moebious doctor from Ironhammer."

Be from Shimatangeku
Vagabond
"I am a Frozen Star representative, as proven by my ID."

@SirRichardFrancis
Copy link
Member

SirRichardFrancis commented Sep 30, 2022

Be from First Fleet Working as a Moebious Scientist "Hello I am a Moebious doctor from Ironhammer."

Yes, so what?

Be from Shimatangeku Vagabond "I am a Frozen Star representative, as proven by my ID."

I'm from First Expeditionary Fleet = I'm IronHammer Major General. Good point, that makes sense.
Place of origin doesn't imply anything, it only defines location and culture character is coming from, safe to assume that vagabond from Shimatengoku was a nobody there, maybe a janitor or something.

@Humonitarian
Copy link
Contributor

Be from First Fleet Working as a Moebious Scientist "Hello I am a Moebious doctor from Ironhammer."

Yes, so what?

Be from Oberth
Canonically Founder member
Free valid?

@SirRichardFrancis
Copy link
Member

Be from Oberth Canonically Founder member Free valid?

Oberth = Founders? Since when? Isn't planet in a state of civil war or something?
Either way, no background is free valid, bruh.

@Iglpigl
Copy link
Contributor Author

Iglpigl commented Sep 30, 2022

According to daget lore they are probably sucking Empresses feet while bolstering forces of space Bulgaria.

@ValoTheValo
Copy link
Contributor

Honestly they should probably be fixed to display planet and employer so youll get something like
Sally Bottles
Job: Scientist
Faction: Moebius Laboratories
Home System: Oberth

Fix dont remove

Copy link
Contributor

@TheShown911 TheShown911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants