Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nanites.dm #8520

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

AltHit
Copy link
Contributor

@AltHit AltHit commented Aug 20, 2024

About The Pull Request

Band-aid fixtng FBP nanites, now they are at least working

Why It's Good For The Game

Not working chem = not gud for game => Fixed chem = Good for the game

Testing

Broke my own ribcage with with a cleaver to test if repair works
Then started up test server, drunk 10u. of nanites [VV shows 0.75 CE_MECH_REPAIR]. Made few organ wounds to myself in a natural way, organ wounds don't heal because CE_MECH_REPAIR is lower than 0.85. Added aluminum, iron and copper to nanites [VV shows 0,9 CE_MECH_REPAIR]. Wounds healed.

Changelog

🆑
fix: repair nanites for FBP now work correctly and heal
/:cl:

Band-aid fixtng FBP nanites, now they are at least working
Copy link
Contributor

@SirRichardFrancis SirRichardFrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to object that we have 9 easily obtainable metals and so it would be easy get the necessary numbers in-game, but...
Testing reminded me that our chemistry system is fundamentally idiotic and doesn't work the way anyone may expect.
Anyways, this "metals boost/required for nanite healing" business sounds cool on paper, but as far as I see it have proved to be unnecessary and plain bad, dysfunctional game mechanic.
Then again, if you say it's okay with the fix, then it probably is.

@AltHit
Copy link
Contributor Author

AltHit commented Aug 25, 2024

I wanted to object that we have 9 easily obtainable metals and so it would be easy get the necessary numbers in-game, but... Testing reminded me that our chemistry system is fundamentally idiotic and doesn't work the way anyone may expect. Anyways, this "metals boost/required for nanite healing" business sounds cool on paper, but as far as I see it have proved to be unnecessary and plain bad, dysfunctional game mechanic. Then again, if you say it's okay with the fix, then it probably is.

Well... This fix is in no way a final sollution. This little patch here just makes it so this mechanic is at least working (as opposed to being completely broken and non-functional). We are working on rewriting this organ healing system right now and when better solution will be made - we will move there. Until then - drink you unranium and wait

Also thank you so much! I made like 3 PRs and this is first real review I got in weeks

Copy link
Contributor

@Humonitarian Humonitarian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this doesn't create any exploit

@TheShown911 TheShown911 merged commit ce50ada into discordia-space:master Sep 6, 2024
6 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 6, 2024
@AltHit AltHit deleted the FBP-band-aid branch September 7, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants