This repository has been archived by the owner on Jan 8, 2022. It is now read-only.
fix: replace ow with zod #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #58 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 264 264
Branches 33 33
=========================================
Hits 264 264
Continue to review full report at Codecov.
|
|
Definitely zod is the best ♥ first validation scheme in my opinion. Also see: https://github.com/colinhacks/zod#comparison |
kyranet
previously requested changes
Nov 24, 2021
src/interactions/slashCommands/mixins/CommandChannelOptionBase.ts
Outdated
Show resolved
Hide resolved
|
Just like with #56, I'd love to know
|
The answers to both of those are in my comment on #56, #56 (comment) |
vladfrangu
previously requested changes
Nov 25, 2021
src/interactions/slashCommands/mixins/CommandOptionWithChoices.ts
Outdated
Show resolved
Hide resolved
kyranet
suggested changes
Nov 29, 2021
src/interactions/slashCommands/mixins/CommandOptionWithChoices.ts
Outdated
Show resolved
Hide resolved
kyranet
approved these changes
Nov 30, 2021
thebigwolfy
approved these changes
Nov 30, 2021
vladfrangu
approved these changes
Nov 30, 2021
iCrawl
approved these changes
Nov 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Replaces ow with zod.
Status and versioning classification: