Skip to content

Commit

Permalink
fix(GuildChannel): parentID shouldn't be set in the constructor (#4919)
Browse files Browse the repository at this point in the history
  • Loading branch information
@NotSugden
NotSugden committed Oct 19, 2020
1 parent 94c9cc2 commit 250c3ae
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/structures/GuildChannel.js
View file
Expand Up @@ -32,8 +32,6 @@ class GuildChannel extends Channel {
* @type {Guild}
*/
this.guild = guild;

This comment was marked as off-topic.

Sign in to view

Copy link
@abde-naizak

abde-naizak Nov 5, 2020

.
this.parentID = null;
}

_patch(data) {
Expand Down

4 comments on commit 250c3ae

@Mola19
Copy link

@Mola19 Mola19 commented on 250c3ae Oct 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please push it to npm? The error is still in 12.4.0

@advaith1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm i discordjs/discord.js

@Mola19
Copy link

@Mola19 Mola19 commented on 250c3ae Oct 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thanks, is there a reason this is updated and the other one not? Is this one directly taking the github repo?

@almostSouji
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discordjs/discord.js installs the default branch from github, yes. Released versions are published on NPM, however waiting for other bugs to appear for a bit is not an uncommon thing to do.

The fix is now released and published on NPM as 12.4.1

Please sign in to comment.