Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(GuildChannel): parentID shouldn't be set in the constructor #4919

Merged
merged 1 commit into from Oct 19, 2020
Merged

fix(GuildChannel): parentID shouldn't be set in the constructor #4919

merged 1 commit into from Oct 19, 2020

Conversation

NotSugden
Copy link
Contributor

@NotSugden NotSugden commented Oct 19, 2020 •
edited

Please describe the changes this PR makes and why it should be merged:
fixes #4918
fixes an issue that my PR #4845 introduced - setting GuildChannel#parentID to null in the constructor

Status

  • Code changes have been tested against the Discord API, or there are no code changes
    • untested but i will test it later to make sure
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@iCrawl iCrawl merged commit 250c3ae into discordjs:master Oct 19, 2020
@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Closed
@NotSugden NotSugden deleted the patch-1 branch July 28, 2021 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot get parent or parentID of a channel.
5 participants
@NotSugden @vladfrangu @iCrawl @kyranet @almostSouji