types(Message#activity): make partyId optional and use enum for `ty…

…pe` (#7845)
discordjs · Apr 25, 2022 · bfeaf85 · bfeaf85
1 parent 3617093
commit bfeaf85
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/packages/discord.js/src/index.js b/packages/discord.js/src/index.js
@@ -197,6 +197,7 @@ exports.InteractionType = require('discord-api-types/v10').InteractionType;
 exports.InteractionResponseType = require('discord-api-types/v10').InteractionResponseType;
 exports.InviteTargetType = require('discord-api-types/v10').InviteTargetType;
 exports.Locale = require('discord-api-types/v10').Locale;
+exports.MessageActivityType = require('discord-api-types/v10').MessageActivityType;
 exports.MessageType = require('discord-api-types/v10').MessageType;
 exports.MessageFlags = require('discord-api-types/v10').MessageFlags;
 exports.OAuth2Scopes = require('discord-api-types/v10').OAuth2Scopes;

diff --git a/packages/discord.js/src/structures/Presence.js b/packages/discord.js/src/structures/Presence.js
@@ -9,7 +9,7 @@ const Util = require('../util/Util');
  * Activity sent in a message.
  * @typedef {Object} MessageActivity
  * @property {string} [partyId] Id of the party represented in activity
- * @property {number} [type] Type of activity sent
+ * @property {MessageActivityType} type Type of activity sent
  */
 
 /**

diff --git a/packages/discord.js/typings/index.d.ts b/packages/discord.js/typings/index.d.ts
@@ -116,6 +116,7 @@ import {
   VideoQualityMode,
   LocalizationMap,
   LocaleString,
+  MessageActivityType,
 } from 'discord-api-types/v10';
 import { ChildProcess } from 'node:child_process';
 import { EventEmitter } from 'node:events';
@@ -4746,8 +4747,8 @@ export type ActionRowComponentOptions = ButtonComponentData | SelectMenuComponen
 export type MessageActionRowComponentResolvable = MessageActionRowComponent | ActionRowComponentOptions;
 
 export interface MessageActivity {
-  partyId: string;
-  type: number;
+  partyId?: string;
+  type: MessageActivityType;
 }
 
 export interface BaseButtonComponentData extends BaseComponentData {
@@ -5420,6 +5421,7 @@ export {
   ThreadMemberFlags,
   UserFlags,
   WebhookType,
+  MessageActivityType,
 } from 'discord-api-types/v10';
 export * from '@discordjs/builders';
 export { DiscordAPIError, HTTPError, RateLimitError } from '@discordjs/rest';