Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types(Message#activity): make partyId optional and use enum for type #7845

Merged
merged 1 commit into from
Apr 25, 2022
Merged

types(Message#activity): make partyId optional and use enum for type #7845

merged 1 commit into from
Apr 25, 2022

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Apr 25, 2022

Please describe the changes this PR makes and why it should be merged:
https://discord.com/developers/docs/resources/channel#message-object-message-activity-structure

  • partyId is optional and type is required
  • changed the type of type to MessageActivityType

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@SpaceEEC SpaceEEC added this to the discord.js v14 milestone Apr 25, 2022
@iCrawl iCrawl merged commit bfeaf85 into discordjs:main Apr 25, 2022
@almeidx almeidx deleted the message-activity-type branch April 25, 2022 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
packages:discord.js semver:major
Projects
discord.js
Archived in project
Milestone
discord.js v14
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@almeidx @vladfrangu @iCrawl @kyranet @SpaceEEC