Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: export "ESM" types when discord.js is imported in ESM land #10009

Merged
merged 2 commits into from
Nov 30, 2023
Merged

fix: export "ESM" types when discord.js is imported in ESM land #10009

merged 2 commits into from
Nov 30, 2023

Conversation

vladfrangu
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

Closes #9985

Status and versioning classification:

  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vladfrangu vladfrangu requested a review from a team as a code owner November 30, 2023 22:37
@vercel Vercel
Copy link

vercel bot commented Nov 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2023 11:18pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Nov 30, 2023 11:18pm

@Jiralite Jiralite added this to the discord.js 14.15 milestone Nov 30, 2023
@Jiralite Jiralite mentioned this pull request Nov 30, 2023
Merged
ckohen
ckohen approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@ckohen ckohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so stupid, thanks TS

@kodiakhq kodiakhq bot merged commit e412a22 into main Nov 30, 2023
7 checks passed
@kodiakhq kodiakhq bot deleted the fix/fake-esm-in-djs branch November 30, 2023 23:19
@whizbangpop whizbangpop mentioned this pull request May 25, 2024
Open
@lockyz lockyz mentioned this pull request May 25, 2024
Closed
@HowlingArcher HowlingArcher mentioned this pull request May 25, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request May 25, 2024
Open
@WhyAydan WhyAydan mentioned this pull request May 26, 2024
Open
@User5029 User5029 mentioned this pull request May 26, 2024
Open
@StrezlessMusick StrezlessMusick mentioned this pull request May 26, 2024
Open
@The0mikkel The0mikkel mentioned this pull request May 26, 2024
Closed
@Azzraya Azzraya mentioned this pull request May 26, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request May 26, 2024
Open
@User5029 User5029 mentioned this pull request May 26, 2024
Open
@AzhamProdLive AzhamProdLive mentioned this pull request May 26, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request May 26, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Jun 26, 2024
Open
@paulsybrandy paulsybrandy mentioned this pull request Jul 7, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Jul 13, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Jul 13, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Jul 13, 2024
Open
@Azzraya Azzraya mentioned this pull request Jul 13, 2024
Open
@whizbangpop whizbangpop mentioned this pull request Jul 13, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Jul 16, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Jul 16, 2024
Open
@whizbangpop whizbangpop mentioned this pull request Jul 16, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Jul 16, 2024
Open
@Azzraya Azzraya mentioned this pull request Jul 16, 2024
Open
@WontonSam WontonSam mentioned this pull request Jul 16, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Jul 17, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Jul 17, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Jul 17, 2024
Open
@Azzraya Azzraya mentioned this pull request Jul 17, 2024
Open
@TheGamerzs TheGamerzs mentioned this pull request Jul 21, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Jul 24, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Jul 24, 2024
Open
@whizbangpop whizbangpop mentioned this pull request Jul 24, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Jul 24, 2024
Open
@Azzraya Azzraya mentioned this pull request Jul 24, 2024
Open
@Pxntricia Pxntricia mentioned this pull request Jul 25, 2024
Open
@WontonSam WontonSam mentioned this pull request Jul 26, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Jul 29, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Jul 29, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Jul 29, 2024
Open
@Azzraya Azzraya mentioned this pull request Jul 29, 2024
Open
@whizbangpop whizbangpop mentioned this pull request Jul 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckohen ckohen ckohen approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

Assignees
No one assigned
Labels
packages:discord.js semver:patch
Projects
discord.js
Archived in project
Milestone
discord.js 14.15
5 participants
@vladfrangu @ckohen @iCrawl @kyranet @Jiralite