-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: make builders types great again #10026
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #10026 +/- ##
==========================================
- Coverage 58.49% 58.47% -0.03%
==========================================
Files 242 243 +1
Lines 17255 17119 -136
Branches 1246 1236 -10
==========================================
- Hits 10093 10010 -83
+ Misses 7117 7064 -53
Partials 45 45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1c3c992
to
a337709
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it still works, LGTM
Please describe the changes this PR makes and why it should be merged:
Simplify builders types to have better docs while (hopefully) not losing functionality or correctness.
Resolves #9292
Status and versioning classification: