Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make builders types great again #10026

Merged
merged 7 commits into from Jan 22, 2024

Conversation

Qjuh
Copy link
Contributor

@Qjuh Qjuh commented Dec 4, 2023

Please describe the changes this PR makes and why it should be merged:

Simplify builders types to have better docs while (hopefully) not losing functionality or correctness.

Resolves #9292

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Copy link

vercel bot commented Dec 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2024 2:59pm
discord-js-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2024 2:59pm

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (1431c18) 58.49% compared to head (a1eb68d) 58.47%.
Report is 3 commits behind head on main.

Files Patch % Lines
...ractions/slashCommands/mixins/SharedSubcommands.ts 97.07% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10026      +/-   ##
==========================================
- Coverage   58.49%   58.47%   -0.03%     
==========================================
  Files         242      243       +1     
  Lines       17255    17119     -136     
  Branches     1246     1236      -10     
==========================================
- Hits        10093    10010      -83     
+ Misses       7117     7064      -53     
  Partials       45       45              
Flag Coverage Δ
builders 95.56% <98.12%> (+0.03%) ⬆️
next ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Qjuh Qjuh marked this pull request as ready for review December 4, 2023 14:20
@Qjuh Qjuh requested a review from a team as a code owner December 4, 2023 14:20
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it still works, LGTM

@kodiakhq kodiakhq bot merged commit a0c83a2 into discordjs:main Jan 22, 2024
6 checks passed
@Qjuh Qjuh deleted the refactor/builders-types branch January 28, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Make builders types great again
4 participants