fix(Webhook): check whether user is null during patching #10049
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
While fetching a webhook using the
Client#fetchWebhook
method, it is possible for the Discord API to send a response with some properties set to null and others not defined.While creating a new instance of the Webhook class, the _patch method will check whether or not a property was returned using the
in
operator. An issue then arises when the property "user" is null: the check'user' in data
evaluates totrue
(the property is indeed in data, it's just set to the value "null") and a null value is then sent toCachedManager#_add
, which attempts to access the propertyid
in a null value.The following is the relevant stack trace of the error I encountered:
And this is the offending Discord API response, obtained by logging the immediate response (Client.js ln312) to the console:
Status and versioning classification: