feat: allow RestOrArray for command option builders #10175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change ApplicationCommandOption methods to allow both rest and array params, which previously wasn't consistent with other builders.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
Jiralite
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10175 +/- ##
==========================================
+ Coverage 62.19% 62.36% +0.16%
==========================================
Files 209 209
Lines 16316 16282 -34
Branches 1214 1213 -1
==========================================
+ Hits 10148 10154 +6
+ Misses 6123 6083 -40
Partials 45 45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kyranet
approved these changes
Mar 14, 2024
vladfrangu
approved these changes
Mar 20, 2024
almeidx
approved these changes
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR changes ApplicationCommandOption methods to allow both rest and array params, which previously wasn't consistent with other builders. This was done by widening the parameter from
...T[]toRestOrArray<T>and normalizing it inside the method. Since arrays are still allowed, this is not a breaking change. The test file has been modified to test both rest and array parameters.Status and versioning classification: