refactor: native zlib support

[sdanialraza]

This reverts #10314 which was a revert of #10243

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
discord-js	⬜️ Ignored (Inspect)	Visit Preview		Jun 2, 2024 10:44pm
discord-js-guide	⬜️ Ignored (Inspect)	Visit Preview		Jun 2, 2024 10:44pm

[codecov]

Codecov Report

Attention: Patch coverage is 27.27273% with 112 lines in your changes are missing coverage. Please review.

Project coverage is 19.13%. Comparing base (17d4c78) to head (663bd00).

Files	Patch %	Lines
packages/ws/src/ws/WebSocketShard.ts	18.84%	112 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main   #10316       +/-   ##
===========================================
- Coverage   47.49%   19.13%   -28.37%     
===========================================
  Files          75       31       -44     
  Lines        9790     6250     -3540     
  Branches      222      111      -111     
===========================================
- Hits         4650     1196     -3454     
+ Misses       5140     5054       -86     

Flag	Coverage Δ
brokers	19.13% <27.27%> (-28.37%)	⬇️
builders	19.13% <27.27%> (-28.37%)	⬇️
collection	19.13% <27.27%> (-28.37%)	⬇️
discord.js	19.13% <27.27%> (-28.37%)	⬇️
formatters	19.13% <27.27%> (-28.37%)	⬇️
guide	19.13% <27.27%> (-28.37%)	⬇️
next	19.13% <27.27%> (-28.37%)	⬇️
proxy	19.13% <27.27%> (-28.37%)	⬇️
rest	19.13% <27.27%> (-28.37%)	⬇️
util	19.13% <27.27%> (-28.37%)	⬇️
utilities	19.13% <27.27%> (-28.37%)	⬇️
voice	19.13% <27.27%> (-28.37%)	⬇️
website	19.13% <27.27%> (-28.37%)	⬇️
ws	19.13% <27.27%> (-28.37%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dzlandis]

How are users of the regular discord.js package supposed to enable native zlib support?
Previously it was auto enabled (at least tmk) when the user had the zlib-sync package installed. But how does one enable it with the native package?

[Qjuh]

This will be in a new major version of @discordjs/ws because of breaking changes. And because of that won’t be in mainlib discord.js before the next major version either. And by then the @discordjs/ws would be used directly in mainlib, not Frankensteined in like I did for the non-breaking change in v14. So then you‘d just set it with the ws options on ClientOptions