Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct base path for GIF stickers #10330

Merged
merged 4 commits into from
Jun 7, 2024
Merged

fix: Correct base path for GIF stickers #10330

merged 4 commits into from
Jun 7, 2024

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Jun 6, 2024

Please describe the changes this PR makes and why it should be merged:
GIF stickers must be accessed via the media proxy.1

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Footnotes

  1. https://discord.com/developers/docs/reference#image-formatting-cdn-endpoints

Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Jun 7, 2024 3:15pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jun 7, 2024 3:15pm

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.07%. Comparing base (7f60a8f) to head (5f06b95).

Additional details and impacted files
@@             Coverage Diff             @@
##             main   #10330       +/-   ##
===========================================
+ Coverage   19.37%   41.07%   +21.70%     
===========================================
  Files          32       49       +17     
  Lines        6267     8944     +2677     
  Branches      115      392      +277     
===========================================
+ Hits         1214     3674     +2460     
- Misses       5053     5267      +214     
- Partials        0        3        +3     
Flag Coverage Δ
proxy 78.52% <ø> (+59.38%) ⬆️
rest 92.68% <100.00%> (+73.54%) ⬆️
ws 51.73% <ø> (+32.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jiralite Jiralite linked an issue Jun 6, 2024 that may be closed by this pull request
@ckohen
Copy link
Member

ckohen commented Jun 7, 2024

(not blocking on it, but tests would be nice)

@kodiakhq kodiakhq bot merged commit 599ad3e into main Jun 7, 2024
24 checks passed
@kodiakhq kodiakhq bot deleted the fix/sticker-gif-path branch June 7, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Wrong base URL for GIF stickers
4 participants