Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add user-installable apps support #10348

Merged
merged 8 commits into from
Jun 27, 2024

Conversation

TAEMBO
Copy link
Contributor

@TAEMBO TAEMBO commented Jun 12, 2024

Please describe the changes this PR makes and why it should be merged:
This PR adds support for user installable apps.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@TAEMBO TAEMBO requested a review from a team as a code owner June 12, 2024 22:49
Copy link

vercel bot commented Jun 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Jun 27, 2024 6:50pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jun 27, 2024 6:50pm

@Jiralite
Copy link
Member

Jiralite commented Jun 12, 2024

Quick question, why are these addX() and not setX()?

@vladfrangu
Copy link
Member

I concur with @Jiralite here, they should be setX. To be honest addX rarely makes sense in the context of a command builder

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.29%. Comparing base (b8397b2) to head (66d35c1).

Additional details and impacted files
@@             Coverage Diff             @@
##             main   #10348       +/-   ##
===========================================
+ Coverage   50.10%   63.29%   +13.18%     
===========================================
  Files         228      131       -97     
  Lines       20533    16426     -4107     
  Branches     1236     1143       -93     
===========================================
+ Hits        10289    10397      +108     
+ Misses      10199     5984     -4215     
  Partials       45       45               
Flag Coverage Δ
builders 95.91% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jiralite Jiralite removed the blocked label Jun 27, 2024
@kodiakhq kodiakhq bot merged commit 9c76bbe into discordjs:main Jun 27, 2024
24 checks passed
@TAEMBO TAEMBO deleted the contexts-and-integration-types branch June 27, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Support installation_types for slash command builders
4 participants