Fix for sending files with Webhook class #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devsnek
pushed a commit
to devsnek/discord.js
that referenced
this pull request
May 14, 2017
devsnek
pushed a commit
to devsnek/discord.js
that referenced
this pull request
May 14, 2017
Ratismal
pushed a commit
to Ratismal/discord.js
that referenced
this pull request
Jul 5, 2017
This was referenced Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
I hope this is the correct branch to PR to.
Sending a file with the webhook currently throws an error.
This will take care of that and allow sending multiple at once.
Tested with a Buffer, local path and an URL.
Also the documentation for other methods are slightly off or wrong,
not sure if this should be in this PR, therefore left them out.
If they should be part of this PR, I could add them, shouldn't be that much.
Semantic versioning classification: